cluster-api-provider-hetzner icon indicating copy to clipboard operation
cluster-api-provider-hetzner copied to clipboard

Published 20 hours ago • verified publisher icon syself

Customize LoadBalancer Name

Open simonostendorf opened this issue 1 year ago • 5 comments

/kind feature

Describe the solution you'd like I would like to name the API Server LoadBalancer using my own naming scheme instead of the default one. The reason for this is that I name all my LBs according to a DNS scheme (e.g. the API Server LB would be named "api..<domain.tld>", as the Ingress LBs would be named "ingress..<domain.tld>". This means that all resources follow the same naming scheme. Is there a reason why the LBs are given a generated name (see https://github.com/syself/cluster-api-provider-hetzner/blob/main/pkg/services/hcloud/loadbalancer/loadbalancer.go#L312)?

Anything else you would like to add: none

Environment:

  • cluster-api-provider-hetzner version: v1.0.0-beta.28
  • Kubernetes version: v1.28.5
  • OS (e.g. from /etc/os-release): Flatcar 3602.2.3

simonostendorf avatar Feb 12 '24 06:02 simonostendorf

There is a feature to own existing load balancers, see https://github.com/syself/cluster-api-provider-hetzner/blob/main/pkg/services/hcloud/loadbalancer/loadbalancer.go#L73.

This currently works by specifying the name of the load balancer.

This would somehow have to be changed if we want to implement this!

janiskemper avatar Feb 12 '24 08:02 janiskemper

This would somehow have to be changed if we want to implement this!

Don't know if other users are interested in this feature. Changing this behavior would be a breaking change which is not what I want :D

simonostendorf avatar Feb 16 '24 13:02 simonostendorf

not necessarily breaking if we add a new property in the spec, but at least a bit ugly since we will have somehow two names, one for existing load balancers, one for naming a new one :sweat_smile:

We can maybe monitor whether people give :+1: for this feature and think whether this is worth implementing!

janiskemper avatar Feb 16 '24 13:02 janiskemper

@simonostendorf sorry for the late reply. Are you still interested in this feature?

If not, please elaborate: Did you find a work-around?

guettli avatar Aug 15 '24 11:08 guettli

@simonostendorf sorry for the late reply. Are you still interested in this feature?

If not, please elaborate: Did you find a work-around?

Would be a cool feature, yes. I am still interested.

simonostendorf avatar Aug 15 '24 12:08 simonostendorf