charts icon indicating copy to clipboard operation
charts copied to clipboard

feat(admission-controller,sysdig-deploy): add initial support for cert-manager

Open yurrriq opened this issue 1 year ago • 5 comments

What this PR does / why we need it:

Fixes #1761

Checklist

  • [x] Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • [x] Chart Version bumped for the respective charts
  • [x] Variables are documented in the README.md (or README.tpl in some charts)
  • [ ] Check GithubAction checks (like lint) to avoid merge-check stoppers
  • [ ] All test files are added in the tests folder of their respective chart and have a "_test" suffix

yurrriq avatar Jun 26 '24 23:06 yurrriq

Hi @yurrriq. Thanks for your PR.

After inspecting your changes someone with write access to this repo needs to approve and run the workflow.

github-actions[bot] avatar Jun 26 '24 23:06 github-actions[bot]

CC @mavimo @AlbertoBarba which team should review and merge? I assume we want to port the changes to the cluster-shield chart too

airadier avatar Jul 05 '24 12:07 airadier

@yurrriq thanks so much for this contribution! We are going to review internally and also port the changes to the cluster-shield chart, as this is now the official deployment method for Admission Controller.

Thanks again.

airadier avatar Jul 05 '24 12:07 airadier

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

github-actions[bot] avatar Sep 04 '24 01:09 github-actions[bot]

This PR has been closed due to inactivity.

github-actions[bot] avatar Sep 11 '24 01:09 github-actions[bot]

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

github-actions[bot] avatar Nov 12 '24 02:11 github-actions[bot]

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

github-actions[bot] avatar Jan 15 '25 02:01 github-actions[bot]

This PR has been closed due to inactivity.

github-actions[bot] avatar Jan 22 '25 02:01 github-actions[bot]