snapshottest
snapshottest copied to clipboard
Use importlib instead of imp
Use importlib instead of imp, fixes #166
@syrusakbary would you mind taking a look and merging the PR? This issue is currently blocking my effort in one of the projects to move to Python 3.12
Any chance in merging this one? 🙏 @paulmelnikow
Tested with both python3.10 and python3.12. Can confirm 3.10 is still working and 3.12 is now also working. Any change of merging?
I used the following in our Pipenv file to reference this branch, to run our tests
snapshottest = { git = "https://github.com/syrusakbary/snapshottest.git", ref ="refs/pull/168/head"}
Hello :wave: ! Is there any chance this might merged soon? Would love to have the package ready for py 3.12. Much appreciated!
Yeah, tripping over this as soon as I try to use python 3.12; approving it would be swell.
@Waszker || @paulmelnikow || @syrusakbary , please merge and release. This fix is critical for supporting python 3.12.
@Waszker || @paulmelnikow || @syrusakbary , please merge and release. This fix is critical for supporting python 3.12.
Sorry @RobinTail I gave my approval but I don't have write access to merge the changes. I'm also waiting for the fix to be finally deployed (it's been 6 months now), in the meantime I suggest using the suggestion from https://github.com/syrusakbary/snapshottest/pull/168#issuecomment-1876960505
I just changed to use syrupy instead. Migration was easy as 🍰
I just changed to use syrupy instead. Migration was easy as 🍰
What about Django support? I have one project that uses django test runner which seems not supported by syrup. I'd be happy to make a switch as well!
I just changed to use syrupy instead. Migration was easy as 🍰
it does not support unittest
, only pytest
, right, @torarvid ?
it's been 6 months now
Almost 9 since the PR date. And more than 11 since the issue #166 opening.
And 3.5 years from the last 1.0.0a0 alpha release.
Maybe it's time to talk about forking, if anyone is interested in undertaking the commitment of continued maintenance.
it does not support
unittest
, onlypytest
, right, @torarvid ?
I don't know, @RobinTail. But we use pytest, so if you're correct, I wouldn't have noticed any problem 😊
I opened another PR before I saw this one.
@paulmelnikow @syrusakbary My implementation is much simpler, and therefore, I hope more likely to be accepted.
- https://github.com/syrusakbary/snapshottest/pull/173