syphon icon indicating copy to clipboard operation
syphon copied to clipboard

[feature] Note To Self

Open EdGeraghty opened this issue 3 years ago • 15 comments

Types

  • [ ] Fix (non-breaking change which fixes an issue)
  • [x] Feature (non-breaking change which adds functionality)
  • [ ] Refactor (non-breaking change which improves code quality - QA thoroughly )
  • [ ] Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Chore (updates that would not affect or change the code involving the app itself)

Changes

🔮 Features

Notes to Self

🐛 Fixes

🔒 Security

🛠 Performance

📐 Refactoring

Media (if applicable)

QA

  • [ ] Signup
  • [ ] Login
  • [ ] Logout
  • [ ] Unencrypted Chat
  • [ ] Encrypted Chat
  • [ ] Group Chats
  • [ ] Profile Changes
  • [ ] Theming Changes
  • [ ] Force Kill and Restart

Final Checklist

  • [x] All associated issues have been linked to PR
  • [ ] All necessary changes made to the documentation
  • [ ] Parties interested in these changes have been notified

EdGeraghty avatar Feb 15 '22 18:02 EdGeraghty

very strange, i'll take a look. I have a feeling it's some code block associated with sending keys properly only when another non-currentUser is in the room.

ereio avatar Feb 16 '22 01:02 ereio

Interestingly, it's also unable to decrypt messages sent by Element, although Element is perfectly happy with the room as configured. It's something to do with loadMessageSessionInbound, but I'm just chasing my tail in circles haha

EdGeraghty avatar Feb 16 '22 16:02 EdGeraghty

I've logged out and back in, and suddenly these rooms work as expected 🤦‍♂️

EdGeraghty avatar Feb 18 '22 16:02 EdGeraghty

@EdGeraghty can you pull the latest changes from dev? Want to see if it changes anything; it affects messageSessionInbound keys.

ereio avatar Feb 21 '22 02:02 ereio

@ereio I have rebased on Dev and all seems good

image

EdGeraghty avatar Feb 21 '22 13:02 EdGeraghty

not sure what happened with this merge but it looks like it's attempting to recommit previous work?

would you mind rebase your changes on top of dev instead? Happy to attempt doing it as well

ereio avatar Feb 22 '22 01:02 ereio

let me know if/when you'd like me to take a look at this!

ereio avatar Mar 18 '22 17:03 ereio

Yes - sorry, I got a little lost in the best way to implement the room avatar and then got sidetracked on other stuff.

EdGeraghty avatar Mar 19 '22 01:03 EdGeraghty

I've rebased this and it's still working as expected. The last step is to work out how to set the room avatar - is this a good/silly approach so far?

EdGeraghty avatar Mar 30 '22 18:03 EdGeraghty

image

As you can see, I'm very close but the Avatar Widget is throwing an AppState error which is what ends up being set haha

EdGeraghty avatar Apr 20 '22 09:04 EdGeraghty

image I've only gone and done it...!

EdGeraghty avatar Apr 20 '22 13:04 EdGeraghty

Fixes #560

EdGeraghty avatar Apr 20 '22 13:04 EdGeraghty

image

I think this looks excellent Ed! Well done!

dnisbetjones avatar Apr 20 '22 14:04 dnisbetjones

Great work @EdGeraghty !

I'd like to make sure a few things are handled properly before merging. Have you tested what happens when a user searches themselves again after they've created a Note To Self? Does it automatically navigate them there like existing user DMs?

Thanks :)

I have 100% tested this in the past, but the code has gone through so many iterations that having just tested it now it seems to sit and hang rather than redirect... Is #671 related? 🤔

EdGeraghty avatar Apr 20 '22 14:04 EdGeraghty

I'd like to add, "Note to Self" should be made by default. If an user attempts to send an message to themselves

UnixPhonez avatar Jun 28 '22 00:06 UnixPhonez