syphon
syphon copied to clipboard
[feature] Note To Self
Types
- [ ] Fix (non-breaking change which fixes an issue)
- [x] Feature (non-breaking change which adds functionality)
- [ ] Refactor (non-breaking change which improves code quality - QA thoroughly )
- [ ] Breaking Change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Chore (updates that would not affect or change the code involving the app itself)
Changes
🔮 Features
Notes to Self
🐛 Fixes
🔒 Security
🛠 Performance
📐 Refactoring
Media (if applicable)
QA
- [ ] Signup
- [ ] Login
- [ ] Logout
- [ ] Unencrypted Chat
- [ ] Encrypted Chat
- [ ] Group Chats
- [ ] Profile Changes
- [ ] Theming Changes
- [ ] Force Kill and Restart
Final Checklist
- [x] All associated issues have been linked to PR
- [ ] All necessary changes made to the documentation
- [ ] Parties interested in these changes have been notified
very strange, i'll take a look. I have a feeling it's some code block associated with sending keys properly only when another non-currentUser is in the room.
Interestingly, it's also unable to decrypt messages sent by Element, although Element is perfectly happy with the room as configured. It's something to do with loadMessageSessionInbound, but I'm just chasing my tail in circles haha
I've logged out and back in, and suddenly these rooms work as expected 🤦♂️
@EdGeraghty can you pull the latest changes from dev? Want to see if it changes anything; it affects messageSessionInbound
keys.
@ereio I have rebased on Dev and all seems good
not sure what happened with this merge but it looks like it's attempting to recommit previous work?
would you mind rebase your changes on top of dev instead? Happy to attempt doing it as well
let me know if/when you'd like me to take a look at this!
Yes - sorry, I got a little lost in the best way to implement the room avatar and then got sidetracked on other stuff.
I've rebased this and it's still working as expected. The last step is to work out how to set the room avatar - is this a good/silly approach so far?
As you can see, I'm very close but the Avatar Widget is throwing an AppState error which is what ends up being set haha
I've only gone and done it...!
Fixes #560
I think this looks excellent Ed! Well done!
Great work @EdGeraghty !
I'd like to make sure a few things are handled properly before merging. Have you tested what happens when a user searches themselves again after they've created a Note To Self? Does it automatically navigate them there like existing user DMs?
Thanks :)
I have 100% tested this in the past, but the code has gone through so many iterations that having just tested it now it seems to sit and hang rather than redirect... Is #671 related? 🤔
I'd like to add, "Note to Self" should be made by default. If an user attempts to send an message to themselves