g2 icon indicating copy to clipboard operation
g2 copied to clipboard

Wrong setting in config

Open lisbravo opened this issue 8 years ago • 3 comments

define A_RADIUS (M1_TRAVEL_PER_REV/(2*3.14159628))

should be (M4_TRAVEL_PER_REV/(2 x 3.14159628)) (had to put a X instead of multiply because the page just makes the calculation)

lisbravo avatar May 25 '16 15:05 lisbravo

Taking a look through some older issues to close out ones that don't seem useful any more.

With this, I've just taken a look at the settings_default.h file, and it's still M1. So this issue may still be relevant.

Thinking about it... the A axis does seem to be commonly used with motor 4. So having the A axis calculations default to using motor 4 seems to make sense. I can create a simple PR to update that if it's useful. :smile:

justinclift avatar Apr 16 '18 15:04 justinclift

Makes sense to make Motor4 the default.

Please keep in mind that some machines (like Othermill) use different motor/axis mappings for physical wiring reasons. I only bring that up here so it's brought to people's attention. We may want a comment that the setting is only a default. But perhaps that obvious by the filename :-)

aldenhart avatar Apr 16 '18 15:04 aldenhart

Yeah, I'll create the PR for the settings_default.h file, but leave the others alone under the assumption they've already been tweaked for their intended purpose.

Which reminds me, I should look into the details of those other machines, then add them to the new "Who uses g2core?" page.

justinclift avatar Apr 16 '18 16:04 justinclift