website icon indicating copy to clipboard operation
website copied to clipboard

Published 20 hours ago • verified publisher icon syntaxfm

Heading levels

Open bripmccann opened this issue 5 years ago • 4 comments

  1. In the show notes, the episode title and section headings are all <h2>s. I checked out the site recently looking for the show notes and scrolled right past. I guess I was looking for a visually distinct heading to mark the title. (And I'm sure there are accessibility issues you know about better than me.)
  2. There's no <h1> on the page. An <h1> was added around the logo in #126 but removed in #190.

bripmccann avatar Apr 09 '19 21:04 bripmccann

@bripmccann feel free to submit a PR to make the show notes title an h1 - pages definitely need an h1 for accessibility and defining the page structure and content hierarchy, not sure what to do about visually making the Show Notes more distinct

sergical avatar Oct 23 '19 03:10 sergical

@416serg would this amount to changing the Show Notes from "##" to "#" in each show's markdown file?

somecatdad avatar Oct 23 '19 03:10 somecatdad

Nope, should be simple, just editing the https://github.com/wesbos/Syntax/blob/master/components/ShowNotes.js file and changing the h2 for show.title

sergical avatar Oct 24 '19 00:10 sergical

That works for the show's title, but I thought the idea was to change it for the "Show Notes" header, too. Looks like that is pulled into ShowNotes.js in the dangerouslySetInnerHTML at https://github.com/wesbos/Syntax/blob/master/components/ShowNotes.js#L32

somecatdad avatar Oct 24 '19 04:10 somecatdad