website icon indicating copy to clipboard operation
website copied to clipboard

Published 20 hours ago • verified publisher icon syntaxfm

Refactor Show.js to be a stateless functional component

Open simeydk opened this issue 6 years ago • 3 comments

simeydk avatar Oct 14 '18 12:10 simeydk

Hey @simeydk, could you combine this and https://github.com/wesbos/Syntax/pull/206 into one stateless functional update?

sergical avatar Oct 23 '18 00:10 sergical

Hi @416serg

I'm happy to combine #201 and #206. However, you have closed both. Should I open a new PR that combines both?

simeydk avatar Oct 23 '18 07:10 simeydk

Hey Simey,

That would be great! 🔥 Make sure to pull in a fresh copy of master and open up a new PR for that 😄

Looking forward to it!

On Tue, Oct 23, 2018 at 3:17 AM Simey de Klerk [email protected] wrote:

Hi @416serg https://github.com/416serg

I'm happy to combine #201 https://github.com/wesbos/Syntax/pull/201 and #206 https://github.com/wesbos/Syntax/pull/206. However, you have closed both. Should I open a new PR that combines both?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/wesbos/Syntax/pull/201#issuecomment-432124406, or mute the thread https://github.com/notifications/unsubscribe-auth/ADlhn40k627XvM7aFa_tMQZExHdDHswxks5unsKGgaJpZM4XbHUS .

sergical avatar Oct 23 '18 14:10 sergical