sinabs icon indicating copy to clipboard operation
sinabs copied to clipboard
verified publisher icon synsense

fix imports for gallery plots

Open kphanipavan opened this issue 6 months ago • 2 comments

Checklist before requesting a review

  • [x] Tests for the changes have been added (for bug fixes/features)
  • [x] Docs have been added / updated (for bug fixes / features)
  • [x] I have performed a self-review of my code
  • [x] Will this be part of a product update? If yes, please write one line about this on the CHANGELOG.md

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Docs fix for neuron dynamics graphs in the gallery section.

  • What is the current behavior? (You can also link to an open issue here) Due to utils import error, the spike plot is not generated for all the neuron models.

Image

  • What is the new behavior (if this is a feature change)? Should render the plots properly instead of an error.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?) No

  • Other information:

kphanipavan avatar Jun 18 '25 06:06 kphanipavan

Took 5 commits, but fixed the plot generation. Had to replicate the plotting function into each file for now. Will revert to importing that function once I create the docs build env locally.

Working version: https://sinabs--290.org.readthedocs.build/290/auto_examples/layers/plot_iaf.html

kphanipavan avatar Jun 18 '25 11:06 kphanipavan

Hi @kphanipavan,

Thank you so much for your contribution. Before merging your PR, as listed in our documentation, I need you to sign our Contributor's License Agreement.

Can I have your email?

Best, Vanessa

ssinhaleite avatar Nov 14 '25 02:11 ssinhaleite

Rejecting the PR since I haven't heard back, and the problem has already been solved.

ssinhaleite avatar Nov 25 '25 03:11 ssinhaleite