react-native-ldk icon indicating copy to clipboard operation
react-native-ldk copied to clipboard

Expo compatibility

Open josefelbez opened this issue 11 months ago • 2 comments

Considering Expo's expanding presence, integrating React Native LDK seamlessly into the Expo workflow seems like a good move, but we currently find two main issues:

  • The Logger class, located in lib/ios/Classes/LdkLogger.swift, causes build failures when using EAS BUILD.
  • Integration with Android requires manual steps, such as adding LDK to android/app/build.gradle. A potential solution could involve creating an Expo custom plugin, allowing developers to simply add the plugin to app.json for seamless integration without the need to modify any native code. This approach aligns with Expo's philosophy and would streamline the process for developers. Reference: Expo Config Plugins.

As for the first issue I already submitted a pr that fixes it and needs to be reviewed, for the second review is a little more complicated so I wanted to ask if that's in your interest and could potentially be merged after reviewed as well, if yes i could assign it to myself and do a pr as well.

PS: I'm talking about EXPO dev client here and not EXPO Go.

josefelbez avatar Feb 29 '24 19:02 josefelbez

Thanks! On your first point, merged here. Regarding the expo plugin, we're not using expo ourselves and so this won't likely be a priority for our dev team over features and bug fixes. But PR's for this are welcome! Provided the lib is still 100% compatible with regular RN projects.

Jasonvdb avatar Mar 04 '24 12:03 Jasonvdb

Thanks for your answer, yes it will still be 100% compatible with RN projects, but at the same way easier to use with expo, soon I'll open a pr. Maybe this will help new devs that have the expo environment to use the react-native-ldk

josefelbez avatar Mar 07 '24 08:03 josefelbez