bitkit icon indicating copy to clipboard operation
bitkit copied to clipboard

[Bug]: Scanning a LN invoice QR fails without error

Open BitcoinErrorLog opened this issue 3 years ago • 6 comments

Describe the bug

If I use the camera scanner to scan a LN QR invoice, it immediately scans then goes back to the previous screen with no effect.

Reproduce

  1. Go to camera scanner from anywhere
  2. Scan a LN QR
  3. No effect after scanning, no ability to pay LN invoice
  4. No error message is given

Screenshots / Recording

No response

Operating system

iOS

Bitkit version

(23)

Log output

No response

BitcoinErrorLog avatar Dec 06 '22 13:12 BitcoinErrorLog

Just tested this as well for a LN QR, cannot confirm this bug, scanner works on my side (23) (iPhone).

aldertnl avatar Dec 06 '22 14:12 aldertnl

It could be the type of invoice being scanned. I tried paying at lnmarkets.com as a deposit -- try both the 0-amount invoice, and try generating a specific one.

BitcoinErrorLog avatar Dec 06 '22 14:12 BitcoinErrorLog

Maybe there is something up with LNmarkets. image

LNmarkets also failed to generate a specific invoice.

aldertnl avatar Dec 06 '22 15:12 aldertnl

Just tried again as the issues on LNmarkets side seem to be resolved. I am getting this error when scanning 0-amount invoice on LNmarkets. Bitkit does seem to be able to parse a specified invoice though (on LNmarkets). @coreyphillips @Jasonvdb @BitcoinErrorLog

E64C96B5-F206-422D-A59B-4F5283B010BD_4_5005_c

aldertnl avatar Dec 06 '22 17:12 aldertnl

When attempting to deposit to LNMarkets without specifying an amount, LNMarkets presents an lnurl-pay string via the qrcode. Unfortunately, Bitkit does not yet support lnurl at this time.

To successfully deposit to LNMarkets in the meantime, an amount must be specified in the textbox below the qrcode. Simply enter the desired amount of satoshis you wish to deposit and click "Request Invoice". This should generate an invoice that Bitkit can recognize.

coreyphillips avatar Dec 08 '22 22:12 coreyphillips

I suppose then that the bug/feature here is to show appropriate error-handling/notification, and/or to add support for lnurl-pay.

BitcoinErrorLog avatar Dec 09 '22 09:12 BitcoinErrorLog

This issue has been addressed here and will be included in the next release.

coreyphillips avatar Jan 03 '23 11:01 coreyphillips

@coreyphillips can I close the issue?

JeanlChristophe avatar Mar 02 '23 13:03 JeanlChristophe

@coreyphillips can I close the issue?

Please keep it open for now. A scanned lightning invoice containing capital letters followed by a colon (Ex: LIGHTNING:) will currently fail. I'll close this issue once that fix is in.

coreyphillips avatar Mar 02 '23 13:03 coreyphillips

I still can't read and pay WoS (zero-amount) QR codes with Bitkit.

BitcoinErrorLog avatar Apr 17 '23 09:04 BitcoinErrorLog

Working for the incoming build 39. If you select lightning invoice in WOS.

https://user-images.githubusercontent.com/5300488/232447162-03f42269-d1b3-4b01-b743-4b444dcbc5c6.MP4

Jasonvdb avatar Apr 17 '23 09:04 Jasonvdb

ohhhh i think i see the issue, it defaults to Lightning Address... lame. I'm still not sure whether we should add support for that...

BitcoinErrorLog avatar Apr 17 '23 09:04 BitcoinErrorLog

Right, yeah then I think every user is going to make that mistake if WOS is always going to default to lightning address

Jasonvdb avatar Apr 17 '23 09:04 Jasonvdb

I never tried talking to them before, let's see... https://twitter.com/BitcoinErrorLog/status/1647901756137914368

BitcoinErrorLog avatar Apr 17 '23 09:04 BitcoinErrorLog

I am closing this issue, we don't support LN address.

JeanlChristophe avatar Jun 06 '23 10:06 JeanlChristophe