bitkit icon indicating copy to clipboard operation
bitkit copied to clipboard

[Feature]: Keyboard entry on MacOS

Open BitcoinErrorLog opened this issue 1 year ago • 3 comments

Describe the problem

Bitkit runs nicely on MacOS, but I wish I could use my physical keyboard to type instead of the onscreen keyboard.

Describe the solution

No response

Additional context

Low-priority, just a little side wish!

BitcoinErrorLog avatar Oct 11 '24 12:10 BitcoinErrorLog

@BitcoinErrorLog Keyboard entry works for me, I don't get the onscreen keyboard. One thing to try is to hit CMD + Shift + K that's how you switch from onscreen to physical in the simulator.

pwltr avatar Nov 07 '24 12:11 pwltr

What about PIN entry?

BitcoinErrorLog avatar Nov 08 '24 11:11 BitcoinErrorLog

What about PIN entry?

It's really only incidental that the app mostly works on MacOS. In the case of the NumberPad (PIN and Amount screens) it is a custom UI and not a <TextInput /> component that only listens to click events. For this issue specifically we can try something like react-native-external-keyboard but if the plan is to support desktop we should think about targeting that more cleanly and keep mobile and desktop code separate since the APIs will vary widly.

pwltr avatar Nov 08 '24 11:11 pwltr