bitkit icon indicating copy to clipboard operation
bitkit copied to clipboard

chore: switch to react-native-vision-camera

Open pwltr opened this issue 1 year ago • 3 comments

Description

Removes react-native-camera-kit and replaces with react-native-vision-camera

Currently seeing a crash on android emulator when giving camera permission.

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [x] Refactoring (improving code without creating new functionality)

Tests

  • [ ] Detox test
  • [ ] Unit test
  • [x] No test

Screenshot / Video

Insert relevant screenshot / recording

QA Notes

Make sure camera/scanner works as expected

pwltr avatar Jun 13 '24 15:06 pwltr

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 1.15 MB mrousavy

🚮 Removed packages: npm/[email protected]

View full report↗︎

socket-security[bot] avatar Jun 13 '24 15:06 socket-security[bot]

Maybe try to upgrade react-native-camera-kit to 14.0.0-beta15 ?

limpbrains avatar Jun 13 '24 19:06 limpbrains

Currently seeing a crash on android emulator when giving camera permission.

This crash happens only on this PR (in the emulator). From what I've seen this camera performs better so switching would be a good idea. Maybe it will be fixed by upgrading to react-native 0.74.

pwltr avatar Jun 14 '24 10:06 pwltr