bitkit
bitkit copied to clipboard
[Bug]: Receive confetti displays for old transaction when Electrum reconnects
Describe the bug
When the connection to Electrum drops and reconnects, I quite often see the confetti screen for a transaction that I received a while ago, possibly even days ago. This issue is fully reproducible. It will celebrate for a transaction I've already seen the confetti for, although, I cannot find the pattern for what transaction is decides to celebrate for.
Reproduce
This has occurred quite a few times for me recently under normal usage so I am confident it would occur in the wild, which could be confusing for users. These steps recreate it for me reliably (same as attached screengrab vid):
- Open Bitkit with a wallet that has some received on-chain transactions
- Go to Electrum Server settings
- Cease all internet connection (airplane mode)
- Wait for "Electrum Connection Failed" message
- Allow internet connection again
- Wait for "Internet Connection Restored"
- Tap "Connect To Host" button (may need to leave Electrum Server settings screen and come back for it to be enabled)
- Observe "Received Bitcoin" confetti screen for a transaction that happened some time ago and you have probably already celebrated.
Screenshots / Recording
https://github.com/synonymdev/bitkit/assets/74595920/60c2270a-0c23-4887-9ef4-df5385696ba1
Operating system
Android 13 TKQ1.220829.002
Bitkit version
c55c045f58b7e76ee82acdc1419bccf9db8490ae
Log output
No response
This happens often to me on wallet restore, so not just in normal use and electrum server reconnects.
This appears to be fixed now, possibly by https://github.com/synonymdev/bitkit/pull/2210
I have recently seen this again when using v1.0.5 (136), but not on wallet restore. It was after initiating a manual transfer, possibly electrum disconnected and reconnected. The UTxO (75201f594cf6fdd1799fa1d5b5741a7ef81347420ff3f861217be97ead88aceb:0 value of 377) it displayed the value for from back in 29th May:
My hunch is that there are multiple refreshes coinciding when Electrum reconnects, which is similar to what was reliably happening on wallet restore before the recent fix.