bitkit icon indicating copy to clipboard operation
bitkit copied to clipboard

[Bug]: Lightning and contacts Backup/Restore do not use BIP-39 passphrase

Open catch-21 opened this issue 10 months ago • 0 comments

Describe the bug

The lightning and contacts backup do not consider the BIP-39 passphrase. They are always restored regardless of passphrase used. Therefore, if your wallet uses a passphrase and you either forget to enter it or enter the wrong passphrase when restoring, although your on-chain transactions and balance will not show, your lightning-related activities and contacts will restore. This could also be a problem for those who want to use multiple accounts derived using different passphrases for the same 12 words, e.g. a fake dummy account.

Reproduce

  1. Create a wallet that uses a passphrase (13th word)
  2. Create profile, add contact, make some on-chain and off-chain transactions and have a balance
  3. Backup your seed phase (12 words)
  4. Reset wallet
  5. Restore with the 12 words and WITHOUT the passphrase
  6. "Wallet Restored." "You have successfully restored your wallet from backup." messages are displayed. Proceed to home screen.
  7. Observe backup of LN transaction Activities and contacts have restored. Profile is new "Your Name" and Balance is zero. No on-chain activities are listed.

Screenshots / Recording

https://github.com/synonymdev/bitkit/assets/74595920/cc257642-ef43-4e88-9de4-080f3f0847cf

Operating system

Android 13 TKQ1.220829.002

Bitkit version

v1.0.0-beta.113

Log output

No response

catch-21 avatar Apr 16 '24 19:04 catch-21