bitkit
bitkit copied to clipboard
feat: android e2e tests
Description
Detox for android
Type of change
Refactoring
Tests
Detox test
Blocked by https://github.com/ReactiveCircus/android-emulator-runner/issues/351
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎
This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
| Package | New capabilities | Transitives | Size | Publisher |
|---|---|---|---|---|
| npm/[email protected] | None | 0 |
311 kB | scarlac |
🚮 Removed packages: npm/[email protected]
Had to push an update, but before that there were a series of 5 uninterrupted successful test runs And before that around 10
wtf
BUILD SUCCESSFUL in 15m 14s
3066 actionable tasks: 3066 executed
After running the build command, Detox could not find your app at the given binary path:
android/app/build/outputs/apk/release/app-release.apk
It's probably because of https://github.com/synonymdev/bitkit/pull/1992, try changing it to app-x86_64-release.apk or app-x86_64-debug.apk
Is it possible only do x86_64 build for detox tests? This might speedup the build/test
yeah I think like this in detoxrc should work (just add the flag):
$ ./gradlew :app:assembleDebug -PreactNativeArchitectures=x86_64
Reviewed the tests and CI runs. We can definitely make some improvements such as remvoing hard-coded waits in favour of checking e.g. that backups have succeeded, but it looks stable and the time saving is not worthwhile at this time. LGTM.