bitkit icon indicating copy to clipboard operation
bitkit copied to clipboard

feat: android e2e tests

Open limpbrains opened this issue 2 years ago • 1 comments

Description

Detox for android

Type of change

Refactoring

Tests

Detox test

limpbrains avatar Nov 01 '23 16:11 limpbrains

Blocked by https://github.com/ReactiveCircus/android-emulator-runner/issues/351

limpbrains avatar Dec 06 '23 15:12 limpbrains

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

socket-security[bot] avatar Jun 15 '24 17:06 socket-security[bot]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 311 kB scarlac

🚮 Removed packages: npm/[email protected]

View full report↗︎

socket-security[bot] avatar Jun 17 '24 12:06 socket-security[bot]

Had to push an update, but before that there were a series of 5 uninterrupted successful test runs And before that around 10

limpbrains avatar Jun 17 '24 12:06 limpbrains

wtf

BUILD SUCCESSFUL in 15m 14s
3066 actionable tasks: 3066 executed
After running the build command, Detox could not find your app at the given binary path:
	android/app/build/outputs/apk/release/app-release.apk

limpbrains avatar Jun 17 '24 12:06 limpbrains

It's probably because of https://github.com/synonymdev/bitkit/pull/1992, try changing it to app-x86_64-release.apk or app-x86_64-debug.apk

pwltr avatar Jun 17 '24 13:06 pwltr

Is it possible only do x86_64 build for detox tests? This might speedup the build/test

limpbrains avatar Jun 17 '24 14:06 limpbrains

yeah I think like this in detoxrc should work (just add the flag):

$ ./gradlew :app:assembleDebug -PreactNativeArchitectures=x86_64

pwltr avatar Jun 17 '24 14:06 pwltr

Reviewed the tests and CI runs. We can definitely make some improvements such as remvoing hard-coded waits in favour of checking e.g. that backups have succeeded, but it looks stable and the time saving is not worthwhile at this time. LGTM.

catch-21 avatar Jul 04 '24 11:07 catch-21