SyliusAkeneoPlugin icon indicating copy to clipboard operation
SyliusAkeneoPlugin copied to clipboard

Introduce ProductFilterInterface::getChannel to allow further extension

Open adrienlucas opened this issue 4 years ago • 1 comments

Q A
Bug fix? no
New feature? no
BC breaks? no
Fixed issue N.A.

Following the introduction of \Synolia\SyliusAkeneoPlugin\Filter\ProductFilterInterface, I replaced the dependency between the ProductFiltersRules repository and the two CreateSimpleProductEntitiesTask and CreateConfigurableProductEntitiesTask by a dependency on ProductFilterInterface. In my case, it allows to reuse those tasks without having to fake the repository.

NB : I was tempted to move the initialization of $this->scope in the constructor of the tasks.. let me know if you find it a good idea !

adrienlucas avatar Aug 23 '21 08:08 adrienlucas

Not sure why the Behat tests are failing...

adrienlucas avatar Aug 23 '21 12:08 adrienlucas