synfig icon indicating copy to clipboard operation
synfig copied to clipboard

Esc key does not cancel dragging anymore

Open Svarov-RZM opened this issue 5 years ago • 7 comments

Description

In Synfig 1.0.2 if you started dragging any handle in work area (vertex, tangent, etc.) you could cancel the operation by hitting 'Esc' key. I use it quite a lot because often you can accidentally hit another handle if there are bunch near.

To reproduce

  • Create an outline
  • Start dragging any handle
  • Try to cancel the operation (dragging) by hitting 'Esc' key

Expected behavior

After hitting 'Esc', the handle must return to its original position without causing any action/rendering. Now if you made a mistake, you have to release the mouse key, wait for render to finish, hit CTRL+Z and wait again for render which is annoying if the work is complex and takes time to render.

Tested on Windows 10, latest Synfig 1.3.12. Maybe issue is related to the fact that CTRL+V now works for text fields? Just a guess though.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Svarov-RZM avatar Feb 08 '20 07:02 Svarov-RZM

Hello there! The feature appears to work correctly for me, can you make a gif out of a demo and share with us?

gkan30 avatar Feb 09 '20 13:02 gkan30

@gkan30 You can watch the video here: https://1drv.ms/v/s!Aqn9-DWzZKfcgVGGxf0t4bEhtOe1?e=y9WdSu Does someone else with Windows 10 experience this bug? Maybe something wrong with my system...

Svarov-RZM avatar Feb 18 '20 18:02 Svarov-RZM

It still works in 1.3.11.

rodolforg avatar Feb 25 '20 04:02 rodolforg

@rodolforg I have the same behavior described by @Svarov-RZM using Windows 10 v1809 while using SynfigStudio-1.3.12-testing-2020.01.30-win64-8b3a3 from https://www.fosshub.com/Synfig-Development.html

Pressing ESC key does NOT "cancel" the spline control point drag operation.

Jose-Moreno avatar Feb 25 '20 20:02 Jose-Moreno

@Jose-Moreno I'll bibisect it to find out when it was broken.

rodolforg avatar Feb 25 '20 20:02 rodolforg

This is the culprit : 6b3c81c2fb73a7a96cfddb0e43de54fe7a61da2e

rodolforg avatar Feb 25 '20 21:02 rodolforg

As spacebar is now used for Play, what about revert this commit 6b3c81c ?

rodolforg avatar Jan 23 '22 03:01 rodolforg