syncthing-android icon indicating copy to clipboard operation
syncthing-android copied to clipboard

Not able to quit Syncthing Android when no Wi-Fi

Open JonatanWick opened this issue 1 year ago • 9 comments

Steps to reproduce:

  1. Disconnect Wi-Fi
  2. Open Syncthing Android
  3. Syncthing disabled message is shown because there is no Wi-Fi
  4. Clicking Exit
  5. Syncthing window closes but Syncthing Android is still running and is not possible to quit.

I must connect to Wi-Fi to quit Syncthing Android.

JonatanWick avatar Aug 03 '22 05:08 JonatanWick

How do you tell it's still running? Because it is in the list of recent tasks?

fps avatar Aug 15 '22 14:08 fps

Becaise a persistent "Syncthing is running" notification appears in the notification area. See screenshot syncthing running .

JonatanWick avatar Aug 15 '22 16:08 JonatanWick

Interesting. In this case it should really say "Syncthing disabled". Is this maybe a translation error?

fps avatar Aug 17 '22 09:08 fps

Sorry, it already says "Syncthing disabled" so the last comment and screenshot is wrong. The only problem is that there is no way to close the application when the Syncthing disabled message appears because there is no Wi-Fi or mobile data.

JonatanWick avatar Aug 17 '22 17:08 JonatanWick

Yeah, that botheres me, too. I guess it would be nice if the "Exit" button on the dialog would really exit the app. Maybe making the dialog have three buttons instead of two worded like "Change settings", "Leave running" and "Exit" would be more appropriate. What do the maintainers think?

fps avatar Aug 22 '22 08:08 fps

Yup, quit or cancel for what's exit now seems more appropriate. And in case the app is not configured to run on boot/as service, then an exit button that actually does the same thing as the menu exit button seems sensible too.

imsodin avatar Aug 22 '22 19:08 imsodin

Hi @fps can you please explain, you pushed some commits, but this is still a problem in v 1.23.4. "Exit" doesn't really Exit (behaves like Cancel) when any condition is missing, like WiFi when only on WiFi or AC when only on AC. Exit should exit Syncthing from running in foreground. And Cancel should just cancel the popup. Note that this is manual exit from foreground, I asked that #1840 be auto exit.

timur-g avatar Apr 18 '23 09:04 timur-g

Hi,

those were pushes to my fork IIRC. Those changes did not make it into syncthing.

fps avatar Apr 18 '23 11:04 fps

When will it be pushed into syncthing?

JonatanWick avatar Apr 19 '23 05:04 JonatanWick