syncthing-android icon indicating copy to clipboard operation
syncthing-android copied to clipboard

whitelisted ssid not whitelisted

Open ghost opened this issue 6 years ago • 17 comments

Screenshot_20190415-224528_Syncthing_1_1 Screenshot_20190415-223239_Syncthing_1_1 Screenshot_20190415-223246_Syncthing_1_1 Screenshot_20190415-223230_Syncthing_1_1

See attached screenshots.

ghost avatar Apr 15 '19 20:04 ghost

Enable location tile?

Catfriend1 avatar Apr 15 '19 21:04 Catfriend1

The location tile is off, see screenshot. Screenshot_20190415-233521_DuckDuckGo_1_1

ghost avatar Apr 15 '19 21:04 ghost

Indeed when enabling location the whitelisting works. Maybe the reason message is better "need location enabled for wifi whitelist check"?

ghost avatar Apr 15 '19 22:04 ghost

Indeed, already being addressed: https://github.com/Catfriend1/syncthing-android/pull/87

ghost avatar Apr 16 '19 00:04 ghost

Unfortunately (but arguably understandable) Google decided that getting a Wifi SSID allows you to look up your approximate location in various databases and therefore tied this to both the location permissions and the location setting. We already have a check for the permission not being granted, but checking the location setting would also be sensible. We should also add it as the reason instead of the misleading "not being whitelisted".

capi avatar Apr 20 '19 22:04 capi

Oh damn it, I'm out of date, disregard my comment, sorry!

capi avatar Apr 20 '19 22:04 capi

Indeed when enabling location the whitelisting works. Maybe the reason message is better "need location enabled for wifi whitelist check"?

Can confirm this. Using Android 9 with Syncthing Version 1.1.1.

pgrunm avatar May 04 '19 11:05 pgrunm

Shall there be an option "Run now" apart from "Change settings" and "Exit"?

It should allow this particular Syncthing session until Wi-Fi is turned off (or some explicit user exit).

vi avatar May 11 '19 01:05 vi

I'm wondering if this solution could be applied here to whitelist a SSID without the need for location.

letkan avatar May 18 '19 07:05 letkan

@letkan: Quote from the answer: "From android 8.0 onwards we wont be getting SSID of the connected network unless GPS is turned on."

capi avatar May 18 '19 07:05 capi

@capi I was referencing answer 9 and bellow it, "I tested this solution in "Pie" and it still working". My main concern is battery.

letkan avatar May 18 '19 07:05 letkan

Ah, I see. Will try that out. But even if it works, I expect that loophole to be closed sooner or later. Google made it very clear that they consider SSID/BSID information to be location relevant. And they are not wrong about that. What we could do is to fallback to this attempt in case the permission was not granted and/or location is turned off. It would not make anything worse. I would not recommend using it for getting rid of the location permission.

capi avatar May 19 '19 09:05 capi

I have this problem currently on miui v11 (android 10) with syncthing version 1.8.0. Location permission is granted.

It worked on 1.7.1 !!

ka223 avatar Aug 17 '20 08:08 ka223

I have location permissions granted to the app "all the time" including precise location, wifi on and connected to a whitelisted said, and have this problem with the latest version (1.20.1) on a pixel 5. Syncthing is always disabled in this situation. This feature does not appear to work correctly.

k3davis avatar May 27 '22 03:05 k3davis

I have this problem on a phone (Asus Zenfone 8, running Android 12) on which 'location' is enabled and Syncthing has permission to access location data. Perhaps the problem is that I use dual band wifi (even though I whitelisted both the wifi networks at issue)?

Also: the feature whereby the app itself mentions prerequisites for using the whitelisting (at least when any such prerequisite is unmet) - has that been implemented yet, please?

Also, cf. #1775.

LinuxOnTheDesktop avatar Oct 23 '22 22:10 LinuxOnTheDesktop

It does seem that part of the problem here is how Syncthing handles dual-band phones. Let me explain.

I was connected to two networks simultaneously and I visited Syncthing's 'run on specified networks' dialogue and only one of those two networks appeared as an option within the dialogue. Later, I revisited the dialogue; and this time both of my networks were shown. And, having selected both of those networks within the dialogue, Syncthing is, for the moment at least, working as it should. That is: I am connected to the two networks; the only-run-on-specified-networks option is on (and the aforementioned two networks the specified ones); and Syncthing is running.

LinuxOnTheDesktop avatar Nov 27 '22 21:11 LinuxOnTheDesktop

A datum: today I was mostly away from home; my phone reports that Syncthing used some 12% of the phone's battery; that large battery drain would not occur were I able to use the whitelist feature; I cannot use the whitelist feature because as reported on this page that feature is broken!

LinuxOnTheDesktop avatar Feb 09 '23 22:02 LinuxOnTheDesktop