ani-skip icon indicating copy to clipboard operation
ani-skip copied to clipboard

[feat] Toggle shortcut for lua script

Open Woreec opened this issue 1 year ago • 8 comments

Adds a shortcut in to the lua script so you can toggle the script by pressing i for the rare cases where the api times are not quite correct or QoL when binging in ani-cli when using -r to for example watch the opening once.

Generally if they are off its only by like half a sentence from expirience, so not a totally necesary feature.

I also added it in to the Readme.md, its fine if you want to have it differently though.

Tested it extensively this time, so there shouldnt be any issues.

Woreec avatar Apr 13 '24 18:04 Woreec

nice profile picture

justchokingaround avatar Apr 13 '24 18:04 justchokingaround

thank you!

Woreec avatar Apr 13 '24 18:04 Woreec

Wouldn't it make sense to only skip once ? Then you would be able to watch the opening/outro by rewinding, and you would also be able to instantly account for skips that are off by a bit.

Commandcracker avatar May 05 '24 00:05 Commandcracker

Wouldn't it make sense to only skip once ?

Then you would be able to watch the opening/outro by rewinding, and you would also be able to instantly account for skips that are off by a bit.

Initially ani-skip only skipped once but then I changed it to skip everytime by taking inspiration from anime streaming sites. Let me take suggestions from few people regarding this issue.

synacktraa avatar May 05 '24 20:05 synacktraa

Yea skipping just once is a good idea, probably better than mine

Something else i did for my script is removing a few seconds from the skip times to jumping 5s before what the op end time is. Might be just personal preference but i rather have a few seconds of the op instead of missing a few seconsds of the episode. Not sure if that is something but i thought i mention it since theres already a small discusion.

Woreec avatar May 05 '24 22:05 Woreec

Something else i did for my script is removing a few seconds from the skip times to jumping 5s before what the op end time is. Might be just personal preference but i rather have a few seconds of the op instead of missing a few seconsds of the episode.

I agree. I think there should be a script-option for it, and switching skipping always or skipping once could also be done with them.

For v2: Skipping times from start are streaming service dependent because some of them have extra intros. Doing skipping times from the end should make the skip times more consistent, but the end sometimes varies between languages and dubs, for example Overlord, it ends after the outro in the original language version, but the dub has some extra stuff at the end. This needs some testing, but it might make ani-skip better. Another thing: A few videos have metadata for segments, using them provides optimal skip times.

Commandcracker avatar May 06 '24 18:05 Commandcracker

A few videos have metadata for segments, using them provides optimal skip times.

Yea, those would be optimal. I wonder if theres a way to make ani-cli prefer ones with them, since right now they are few and far between from my experience.

Woreec avatar May 06 '24 20:05 Woreec

There will be two Lua scripts: skip-once.lua and skip-always.lua. Depending on the user's preference, ani-skip will return the appropriate flag.

synacktraa avatar May 13 '24 06:05 synacktraa