sympy_gamma icon indicating copy to clipboard operation
sympy_gamma copied to clipboard

Published 20 hours ago • verified publisher icon sympy

Tests for SymPy Gamma

Open sahilshekhawat opened this issue 10 years ago • 9 comments

Recently I found out that my PR #33 where i sorted a dictionary actually created another issue with satisfiable which needed another PR #39, So i think we should add tests in Django. This will actually help us a lot while reviewing.

sahilshekhawat avatar May 04 '14 14:05 sahilshekhawat

I want to work on it but first i want to know whether it needs to be done or not, I have done this mistake before

sahilshekhawat avatar May 04 '14 14:05 sahilshekhawat

Yeah. I was going to propose that. Enabling CI will help a lot.

debugger22 avatar May 04 '14 14:05 debugger22

@lidavidm What do you suggest?

sahilshekhawat avatar May 04 '14 14:05 sahilshekhawat

I was thinking we could configure Travis CI to run Python unittests on resultsets.py and to run CasperJS (PhantomJS) tests on the actual UI; Travis supports both.

lidavidm avatar May 04 '14 14:05 lidavidm

Okay, this seems to be a nicer way but I don't know much about Casper/Phantom JS. Let me go through them and then I will send a PR right away. Will ask If I have any trouble. On 4 May 2014 20:18, "David Li" [email protected] wrote:

I was thinking we could configure Travis CI to run Python unittests on resultsets.py and to run CasperJS http://casperjs.org/ (PhantomJShttp://www.phantomjs.org/) tests on the actual UI; Travis supports both.

— Reply to this email directly or view it on GitHubhttps://github.com/sympy/sympy_gamma/issues/42#issuecomment-42134598 .

sahilshekhawat avatar May 04 '14 17:05 sahilshekhawat

Basically, the Python unittests would just make sure that the functions in resultsets.py provide the output that is expected (not necessarily that Gamma is displaying it correctly). Testing that expressions parse correctly would also be nice (as Gamma adds additional capability beyond SymPy's parsing, like synonyms, that SymPy doesn't test). CasperJS is a headless browser; it can render webpages without a GUI and allow JavaScript to inspect and manipulate them. With this we could, for instance:

  • Render each example query and make sure none come up with an error.
  • Click the "show steps" button and make sure the steps show without error.
  • Etc.

Travis CI can be configured to run these tests automatically on pull requests. To run the CasperJS tests we would have to set up Travis to run the development server so that CasperJS can connect to it, thus, we would have to download the App Engine SDK on Travis CI (look this up on Google).

lidavidm avatar May 04 '14 17:05 lidavidm

Ah! Thanks David Okay, I am on to it.

sahilshekhawat avatar May 04 '14 17:05 sahilshekhawat

@sahilshekhawat FYI, I'm working on the Travis configuration right now.

lidavidm avatar May 05 '14 02:05 lidavidm

okay then, i can work on the unit-tests in python. :)

On Mon, May 5, 2014 at 7:49 AM, David Li [email protected] wrote:

@sahilshekhawat https://github.com/sahilshekhawat FYI, I'm working on the Travis configuration right now.

— Reply to this email directly or view it on GitHubhttps://github.com/sympy/sympy_gamma/issues/42#issuecomment-42154838 .

sahilshekhawat avatar May 05 '14 04:05 sahilshekhawat