sympy icon indicating copy to clipboard operation
sympy copied to clipboard

[Fix] removed whitespace .tableform.py

Open samuelard7 opened this issue 1 year ago • 4 comments
trafficstars

References to other Issues or PRs

Brief description of what is fixed or changed

-> Problem with whitespace for some test cases in tableform.py

Other comments

Release Notes

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information on how to write release notes. The bot will check your release notes automatically to see if they are formatted correctly. -->

  • solvers

    • Removed the whitespace.
  • functions

    • changes in _align.

samuelard7 avatar Apr 05 '24 18:04 samuelard7

:white_check_mark:

Hi, I am the SymPy bot. I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.13.

Click here to see the pull request description that was parsed.
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->


#### Brief description of what is fixed or changed

-> Problem with whitespace for some test cases
in tableform.py

#### Other comments


#### Release Notes


See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* solvers
  * Removed the whitespace.

* functions
  * changes in _align.
<!-- END RELEASE NOTES -->

sympy-bot avatar Apr 05 '24 18:04 sympy-bot

Please add a test that would be different now than in master.

smichr avatar Apr 06 '24 01:04 smichr

Please add a test that would be different now than in master.

Sure, I want to ask why the test/author failed I already added my name and email on .mailmap file

samuelard7 avatar Apr 06 '24 02:04 samuelard7

why the test/author failed

The error in the CI job is:

The mailmap file was reordered

    For instructions on updating the .mailmap file see:

https://docs.sympy.org/dev/contributing/new-contributors-guide/workflow-process.html#mailmap-instructions

You need to rerun the script so that the file is in order. This is needed because otherwise everyone chooses (as you did) to add their names at the end of the file which would lead to constant merge conflicts between different PRs.

oscarbenjamin avatar Apr 06 '24 11:04 oscarbenjamin