sympy
sympy copied to clipboard
Changed definition to match use of Transverse_magnification function
References to other Issues or PRs
Changes docstring and html as mentioned in issue #24438
Brief description of what is fixed or changed
Docstring changed to match the result given by the function . The function uses the forumla for mirror but could also be used for a lens since lack of clarification.
Other comments
Release Notes
- physics.optics
- Clarified the use of function
:white_check_mark:
Hi, I am the SymPy bot. I'm here to help you write a release notes entry. Please read the guide on how to write release notes.
- No release notes entry will be added for this pull request.
Click here to see the pull request description that was parsed.
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->
#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->
Changes docstring and html as mentioned in issue #24438
#### Brief description of what is fixed or changed
Docstring changed to match the result given by the function . The function uses the forumla for mirror but could also be used for a lens since lack of clarification.
#### Other comments
#### Release Notes
<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:
* solvers
* Added a new solver for logarithmic equations.
* functions
* Fixed a bug with log of integers. Formerly, `log(-x)` incorrectly gave `-log(x)`.
* physics.units
* Corrected a semantical error in the conversion between volt and statvolt which
reported the volt as being larger than the statvolt.
or if no release note(s) should be included use:
NO ENTRY
See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->
<!-- BEGIN RELEASE NOTES -->
NO ENTRY
<!-- END RELEASE NOTES -->
Can you change the release notes to NO ENTRY
? Minor documentation changes do not need release notes entries, refer to what makes a good release notes entry.
Can you change the release notes to
NO ENTRY
? Minor documentation changes do not need release notes entries, refer to what makes a good release notes entry.
I have changed the entry and read the guidelines for entry , thank you for the help .
Benchmark results from GitHub Actions
Lower numbers are good, higher numbers are bad. A ratio less than 1
means a speed up and greater than 1 means a slowdown. Green lines
beginning with +
are slowdowns (the PR is slower then master or
master is slower than the previous release). Red lines beginning
with -
are speedups.
Significantly changed benchmark results (PR vs master)
Significantly changed benchmark results (master vs previous release)
| Change | Before [a00718ba] | After [ebde6982] | Ratio | Benchmark (Parameter) |
|----------|----------------------|---------------------|---------|----------------------------------------------------------------------|
| - | 69.8±0.7ms | 45.3±0.4ms | 0.65 | integrate.TimeIntegrationRisch02.time_doit(10) |
| - | 68.3±1ms | 44.3±0.2ms | 0.65 | integrate.TimeIntegrationRisch02.time_doit_risch(10) |
| + | 18.5±0.05μs | 29.3±0.7μs | 1.59 | integrate.TimeIntegrationRisch03.time_doit(1) |
| - | 5.43±0.02ms | 2.87±0.01ms | 0.53 | logic.LogicSuite.time_load_file |
| - | 72.1±0.9ms | 28.5±0.1ms | 0.39 | polys.TimeGCD_GaussInt.time_op(1, 'dense') |
| - | 25.8±0.09ms | 16.8±0.05ms | 0.65 | polys.TimeGCD_GaussInt.time_op(1, 'expr') |
| - | 72.4±0.7ms | 29.0±0.3ms | 0.4 | polys.TimeGCD_GaussInt.time_op(1, 'sparse') |
| - | 255±0.8ms | 125±0.9ms | 0.49 | polys.TimeGCD_GaussInt.time_op(2, 'dense') |
| - | 256±0.6ms | 124±0.5ms | 0.49 | polys.TimeGCD_GaussInt.time_op(2, 'sparse') |
| - | 662±8ms | 370±1ms | 0.56 | polys.TimeGCD_GaussInt.time_op(3, 'dense') |
| - | 659±4ms | 370±0.5ms | 0.56 | polys.TimeGCD_GaussInt.time_op(3, 'sparse') |
| - | 489±0.8μs | 286±2μs | 0.59 | polys.TimeGCD_LinearDenseQuadraticGCD.time_op(1, 'dense') |
| - | 1.77±0.01ms | 1.07±0.01ms | 0.6 | polys.TimeGCD_LinearDenseQuadraticGCD.time_op(2, 'dense') |
| - | 5.82±0.05ms | 3.06±0.05ms | 0.53 | polys.TimeGCD_LinearDenseQuadraticGCD.time_op(3, 'dense') |
| - | 449±5μs | 233±2μs | 0.52 | polys.TimeGCD_QuadraticNonMonicGCD.time_op(1, 'dense') |
| - | 1.46±0.01ms | 680±3μs | 0.47 | polys.TimeGCD_QuadraticNonMonicGCD.time_op(2, 'dense') |
| - | 4.88±0.02ms | 1.67±0.01ms | 0.34 | polys.TimeGCD_QuadraticNonMonicGCD.time_op(3, 'dense') |
| - | 377±2μs | 211±2μs | 0.56 | polys.TimeGCD_SparseGCDHighDegree.time_op(1, 'dense') |
| - | 2.44±0.04ms | 1.23±0.01ms | 0.5 | polys.TimeGCD_SparseGCDHighDegree.time_op(3, 'dense') |
| - | 10.1±0.07ms | 4.36±0.02ms | 0.43 | polys.TimeGCD_SparseGCDHighDegree.time_op(5, 'dense') |
| - | 362±3μs | 172±0.9μs | 0.47 | polys.TimeGCD_SparseNonMonicQuadratic.time_op(1, 'dense') |
| - | 2.55±0.03ms | 904±4μs | 0.35 | polys.TimeGCD_SparseNonMonicQuadratic.time_op(3, 'dense') |
| - | 9.48±0.04ms | 2.69±0.01ms | 0.28 | polys.TimeGCD_SparseNonMonicQuadratic.time_op(5, 'dense') |
| - | 1.02±0.01ms | 421±2μs | 0.41 | polys.TimePREM_LinearDenseQuadraticGCD.time_op(3, 'dense') |
| - | 2.33±0.05ms | 502±3μs | 0.22 | polys.TimePREM_LinearDenseQuadraticGCD.time_op(3, 'sparse') |
| - | 6.07±0.05ms | 1.82±0.01ms | 0.3 | polys.TimePREM_LinearDenseQuadraticGCD.time_op(5, 'dense') |
| - | 8.46±0.06ms | 1.50±0.02ms | 0.18 | polys.TimePREM_LinearDenseQuadraticGCD.time_op(5, 'sparse') |
| - | 284±1μs | 63.9±0.3μs | 0.22 | polys.TimePREM_QuadraticNonMonicGCD.time_op(1, 'sparse') |
| - | 3.45±0.03ms | 392±2μs | 0.11 | polys.TimePREM_QuadraticNonMonicGCD.time_op(3, 'dense') |
| - | 3.98±0.02ms | 277±0.7μs | 0.07 | polys.TimePREM_QuadraticNonMonicGCD.time_op(3, 'sparse') |
| - | 7.08±0.07ms | 1.26±0.01ms | 0.18 | polys.TimePREM_QuadraticNonMonicGCD.time_op(5, 'dense') |
| - | 8.77±0.03ms | 835±4μs | 0.1 | polys.TimePREM_QuadraticNonMonicGCD.time_op(5, 'sparse') |
| - | 5.02±0.02ms | 2.99±0.01ms | 0.6 | polys.TimeSUBRESULTANTS_LinearDenseQuadraticGCD.time_op(2, 'sparse') |
| - | 12.1±0.06ms | 6.58±0.02ms | 0.55 | polys.TimeSUBRESULTANTS_LinearDenseQuadraticGCD.time_op(3, 'dense') |
| - | 22.3±0.1ms | 9.14±0.02ms | 0.41 | polys.TimeSUBRESULTANTS_LinearDenseQuadraticGCD.time_op(3, 'sparse') |
| - | 5.23±0.01ms | 881±4μs | 0.17 | polys.TimeSUBRESULTANTS_QuadraticNonMonicGCD.time_op(1, 'sparse') |
| - | 12.6±0.06ms | 7.13±0.02ms | 0.57 | polys.TimeSUBRESULTANTS_QuadraticNonMonicGCD.time_op(2, 'sparse') |
| - | 102±1ms | 25.8±0.1ms | 0.25 | polys.TimeSUBRESULTANTS_QuadraticNonMonicGCD.time_op(3, 'dense') |
| - | 167±2ms | 54.9±0.4ms | 0.33 | polys.TimeSUBRESULTANTS_QuadraticNonMonicGCD.time_op(3, 'sparse') |
| - | 174±0.8μs | 112±0.4μs | 0.64 | polys.TimeSUBRESULTANTS_SparseGCDHighDegree.time_op(1, 'dense') |
| - | 360±2μs | 217±0.9μs | 0.6 | polys.TimeSUBRESULTANTS_SparseGCDHighDegree.time_op(1, 'sparse') |
| - | 4.26±0.01ms | 828±4μs | 0.19 | polys.TimeSUBRESULTANTS_SparseGCDHighDegree.time_op(3, 'dense') |
| - | 5.23±0.02ms | 389±3μs | 0.07 | polys.TimeSUBRESULTANTS_SparseGCDHighDegree.time_op(3, 'sparse') |
| - | 20.1±0.2ms | 2.80±0ms | 0.14 | polys.TimeSUBRESULTANTS_SparseGCDHighDegree.time_op(5, 'dense') |
| - | 22.7±0.2ms | 641±3μs | 0.03 | polys.TimeSUBRESULTANTS_SparseGCDHighDegree.time_op(5, 'sparse') |
| - | 484±4μs | 138±1μs | 0.29 | polys.TimeSUBRESULTANTS_SparseNonMonicQuadratic.time_op(1, 'sparse') |
| - | 4.67±0.02ms | 618±4μs | 0.13 | polys.TimeSUBRESULTANTS_SparseNonMonicQuadratic.time_op(3, 'dense') |
| - | 5.28±0.06ms | 139±1μs | 0.03 | polys.TimeSUBRESULTANTS_SparseNonMonicQuadratic.time_op(3, 'sparse') |
| - | 13.2±0.1ms | 1.28±0.01ms | 0.1 | polys.TimeSUBRESULTANTS_SparseNonMonicQuadratic.time_op(5, 'dense') |
| - | 14.1±0.3ms | 142±0.8μs | 0.01 | polys.TimeSUBRESULTANTS_SparseNonMonicQuadratic.time_op(5, 'sparse') |
| - | 134±0.7μs | 74.3±1μs | 0.55 | solve.TimeMatrixOperations.time_rref(3, 0) |
| - | 256±2μs | 87.5±1μs | 0.34 | solve.TimeMatrixOperations.time_rref(4, 0) |
| - | 24.2±0.1ms | 10.2±0.04ms | 0.42 | solve.TimeSolveLinSys189x49.time_solve_lin_sys |
| - | 28.7±0.2ms | 15.5±0.1ms | 0.54 | solve.TimeSparseSystem.time_linsolve_Aaug(20) |
| - | 56.0±0.8ms | 25.1±0.3ms | 0.45 | solve.TimeSparseSystem.time_linsolve_Aaug(30) |
| - | 28.5±0.2ms | 15.3±0.1ms | 0.54 | solve.TimeSparseSystem.time_linsolve_Ab(20) |
| - | 54.9±0.2ms | 24.7±0.08ms | 0.45 | solve.TimeSparseSystem.time_linsolve_Ab(30) |
Full benchmark results can be found as artifacts in GitHub Actions (click on checks at the top of the PR).