sympy-bot icon indicating copy to clipboard operation
sympy-bot copied to clipboard

Use the same comment for release notes and file added checks

Open sylee957 opened this issue 4 years ago • 4 comments

https://github.com/sympy/sympy/pull/19708

sylee957 avatar Jul 05 '20 13:07 sylee957

I don't see it. I see one comment for the release notes and one for the added files. Was there a comment that was deleted?

asmeurer avatar Jul 06 '20 04:07 asmeurer

Okay, I didn’t know that another comment is added for file deleting.

sylee957 avatar Jul 06 '20 04:07 sylee957

We could merge them into one comment. I just did a separate comment to make it clear that they are separate checks, but maybe it would be cleaner as a single comment.

asmeurer avatar Jul 06 '20 04:07 asmeurer

That would also be better for seeing the history, since currently it deletes the file added comment if the commits are rebased and the added files are removed. But if it were in the same comment, you could still see it in the comment edit history.

asmeurer avatar Jul 06 '20 04:07 asmeurer