sympy-bot icon indicating copy to clipboard operation
sympy-bot copied to clipboard

Recognize co-authored-by in commit messages

Open asmeurer opened this issue 4 years ago • 4 comments

See for example https://github.com/sympy/sympy/pull/19158

asmeurer avatar Apr 21 '20 21:04 asmeurer

https://github.com/sympy/sympy-bot/blob/c600efc24edc6c74fa0837fa5f556dd0aa64f13f/sympy_bot/webapp.py#L82-L91

Searching message in https://github.com/sympy/sympy-bot/blob/c600efc24edc6c74fa0837fa5f556dd0aa64f13f/sympy_bot/webapp.py#L85 for Co-authored-by: author-name <[email protected]> using regex and adding them to users might work ?

iammosespaulr avatar Apr 22 '20 17:04 iammosespaulr

It would be better if there were direct support for it in the GitHub API. The reason is that we need a GitHub username for the release notes.

asmeurer avatar Apr 22 '20 17:04 asmeurer

It would be better if there were direct support for it in the GitHub API. The reason is that we need a GitHub username for the release notes.

Yeah it would! I can't seem to find support for it in the Official API's. However, https://api.github.com/search/[email protected] does provide the username.

iammosespaulr avatar Apr 22 '20 17:04 iammosespaulr

So we can query the email. If we don't get a username from it, we can just include the name and email directly (it doesn't have to be a username, that's just the format we use).

asmeurer avatar Apr 22 '20 18:04 asmeurer