sympy-bot-old icon indicating copy to clipboard operation
sympy-bot-old copied to clipboard

show reviewed pull requests in the "sympy-bot list"

Open certik opened this issue 13 years ago • 3 comments

check that the pull request was tested, and no new patch was added in, by looking at the comments and searching for "sympy-bot".

certik avatar Apr 28 '11 11:04 certik

It's probably better to search for [sympy-bot](https://github.com/sympy/sympy-bot), or even Automatic review by [sympy-bot](https://github.com/sympy/sympy-bot), as people type "sympy-bot" in the comments all the time.

asmeurer avatar Aug 13 '11 07:08 asmeurer

Actually, we probably need to keep track of reviewed SHA1 hashes in some database. The reason is that changed pull requests are not guaranteed to show commits after the latest review comment, particularly when a roll-back is force updated. Also, I never really checked how the commits show up in the API.

We could do this on the app engine, or we could have a simple git repo that everyone can push to that has all the relevant info there (and as I discussed on another issue, we could push up the html pages to gh-pages). I don't know how to use the app engine, so I would personally prefer the latter, unless you or someone who does know how to use the app engine wants to code it up.

asmeurer avatar Aug 16 '11 17:08 asmeurer

Actually, I think just searching comments for SHA1 hashes should work. A database would work too (that's related to #63). Another way would be to implement #132.

asmeurer avatar Nov 08 '12 07:11 asmeurer