sympy-bot-old icon indicating copy to clipboard operation
sympy-bot-old copied to clipboard

Add import time test

Open bgee opened this issue 11 years ago • 11 comments

Add import speed test using bin/test_import.py.

bgee avatar Apr 25 '13 01:04 bgee

You should parse the output of test_import and use the result from there (with the +-).

asmeurer avatar Apr 25 '13 01:04 asmeurer

@asmeurer Just did. https://github.com/sympy/sympy/pull/1924 Also, test_import just assumes it will be called inside sympy/. Should I fix this in sympy? No big deal though. (Sorry I accidentally closed this pull request. )

bgee avatar Apr 25 '13 02:04 bgee

Yes, fix it. Look at all the other various functions to see how (e.g., bin/test).

asmeurer avatar Apr 25 '13 03:04 asmeurer

Could you add a flag to make this configurable (both command line and config file)?

asmeurer avatar Apr 25 '13 03:04 asmeurer

@asmeurer Yes. I will try to finish this before tomorrow afternoon. What will be a good flag? We already have -t. Should we make it default to run? Also, I saw the test you put has a line Test command: ** -V**. It's not showing up on my machine. Did I break anything?

bgee avatar Apr 25 '13 04:04 bgee

No, I tested with -t " -V" so that it wouldn't actually run the tests, so that it would come up quickly.

asmeurer avatar Apr 25 '13 04:04 asmeurer

I guess call it --import-time or --no-import-time (depending on what you make the default).

asmeurer avatar Apr 25 '13 04:04 asmeurer

@asmeurer I use --no-import-time for command line option and no_import_time = false/true in config file.

bgee avatar Apr 26 '13 00:04 bgee

This looks fine. I want to just wait a little bit (maybe a few days) to see if anyone else has any comments.

asmeurer avatar Apr 26 '13 01:04 asmeurer

By the way, you can test comments without spamming a pull request by using --no-comment (-n is also a good idea, since there's no point in uploading the reviews either), then pasting the comment output that is printed to the terminal in an issue in some test GitHub repository (I use https://github.com/asmeurer/GitHub-Issues-Test/issues).

asmeurer avatar Apr 26 '13 01:04 asmeurer

@asmeurer Sounds good. I will also start working on that bin/test_import directory fix.

bgee avatar Apr 26 '13 02:04 bgee