jit_image_manipulation icon indicating copy to clipboard operation
jit_image_manipulation copied to clipboard

Cache disabled + external image = no 304 ever

Open nitriques opened this issue 9 years ago • 1 comments

If you disable the cache, you will never get a 304 on remote image since we (well I) use the temp file's mtime. Is this a problem ? I think we should set the tempfile mtime to the value returned by the server ?

Before 2.0.0, I think it would do the same. Am I right ?

nitriques avatar Aug 02 '16 03:08 nitriques

First, I verified this with JIT 1.43. When the cache is disabled, you will never get a 304 response (but 200 OK). So with this older JIT version, the issue is the same for external and local images alike!

With JIT 2.x (current integration branch) the issue only exists for external images.

I think we should set the tempfile mtime to the value returned by the server ?

Yes, that sounds like a good idea!

michael-e avatar Aug 13 '16 15:08 michael-e