jit_image_manipulation icon indicating copy to clipboard operation
jit_image_manipulation copied to clipboard

Published 20 hours ago • verified publisher icon symphonycms

Shouldn't be able to add a new recipe of type 'New recipe'

Open DavidOliver opened this issue 8 years ago • 8 comments

screenshot from 2016-06-08 14 22 21

In the New recipe adder, there's now a 'New Recipe' select option. Shouldn't this still be 'Direct display' as in previous versions?

DavidOliver avatar Jun 08 '16 12:06 DavidOliver

'Direct display' has never been documented (I was not even aware it existed before I found the rule about it). It was also not implemented in @brendo's refactor into a symphony renderer.

We should add a warning in the README and release notes about this removal.

nitriques avatar Jun 10 '16 00:06 nitriques

Okay, thanks. So the ability to add a new recipie with the 'New recipe' option needs to be disabled then. Renaming issue.

DavidOliver avatar Jun 10 '16 13:06 DavidOliver

Perf!

  • [x] ~~disable button when 'New recipe' is selected~~ Remove the deprecated option completely
  • [x] We should add a warning in the README and release notes about this removal.

nitriques avatar Jun 10 '16 16:06 nitriques

This should also be fixed in the latest integration

nitriques avatar Jun 14 '16 03:06 nitriques

Thanks! I notice the removal of direct mode isn't mentioned in the readme. Will it be noted in the release notes at GitHub?

DavidOliver avatar Jun 14 '16 12:06 DavidOliver

Well direct mode was never part of the readme. But yeah, it will be noted in the release notes on GitHub

nitriques avatar Jun 15 '16 01:06 nitriques

Okeydoke. I only mentioned it as you listed it being in the readme as a todo above. Thanks a lot for sorting this.

DavidOliver avatar Jun 15 '16 09:06 DavidOliver

Thanks for testing!

nitriques avatar Jun 15 '16 22:06 nitriques