jit_image_manipulation
jit_image_manipulation copied to clipboard
Shouldn't be able to add a new recipe of type 'New recipe'
In the New recipe adder, there's now a 'New Recipe' select option. Shouldn't this still be 'Direct display' as in previous versions?
'Direct display' has never been documented (I was not even aware it existed before I found the rule about it). It was also not implemented in @brendo's refactor into a symphony renderer.
We should add a warning in the README and release notes about this removal.
Okay, thanks. So the ability to add a new recipie with the 'New recipe' option needs to be disabled then. Renaming issue.
Perf!
- [x] ~~disable button when 'New recipe' is selected~~ Remove the deprecated option completely
- [x] We should add a warning in the README and release notes about this removal.
This should also be fixed in the latest integration
Thanks! I notice the removal of direct mode isn't mentioned in the readme. Will it be noted in the release notes at GitHub?
Well direct mode was never part of the readme. But yeah, it will be noted in the release notes on GitHub
Okeydoke. I only mentioned it as you listed it being in the readme as a todo above. Thanks a lot for sorting this.
Thanks for testing!