Daemon-Control icon indicating copy to clipboard operation
Daemon-Control copied to clipboard

Single Fork Writes PID (#16 regression)

Open mydimension opened this issue 10 years ago • 3 comments

Looks like #16 regressed. The current version (0.001006) writes a pid file in fork==1 mode when the documentation says it should not.

mydimension avatar Dec 30 '14 15:12 mydimension

Found the commit f657f7862601a107fb6842a2b35229cf0600c553 with explicit changelog message 'properly write the pid file in single fork mode' by @karenetheridge

Also, this bit of code has a comment "make sure pid file exists": https://github.com/symkat/Daemon-Control/blame/master/lib/Daemon/Control.pm#L463 The pid file is created even when fork is set to 0.

I could submit a PR if the correct behavior is pinned down. Let me know.

zoffixznet avatar Jul 30 '15 16:07 zoffixznet

The current POD regarding pid_file and fork would seem to be the target behavior. That is fork<2 results in no pid_file being written, leaving it the responsibility of the program to write it's own pid_file and additionally have it be the file that D::C expects.

mydimension avatar Aug 04 '15 12:08 mydimension

Any update/movement on this?

mydimension avatar Dec 22 '15 15:12 mydimension