webpack-encore icon indicating copy to clipboard operation
webpack-encore copied to clipboard

Published 20 hours ago • verified publisher icon symfony

add svelte support to webpack encore

Open zairigimad opened this issue 4 years ago • 8 comments

Svelte is a radical new approach to building user interfaces. Whereas traditional frameworks like React and Vue do the bulk of their work in the browser, Svelte shifts that work into a compile step that happens when you build your app. https://svelte.dev/

The goal of this PR is to add support of Svelte to Webpack Encore.

  • [ ] Update Documentation https://symfony.com/doc/current/frontend/encore/advanced-config.html#having-the-full-control-on-loaders-rules

zairigimad avatar May 29 '20 21:05 zairigimad

Project made with TypeScript, react.Js, React-native. Recycling day design

https://github.com/Rodrigo001-de/Projeto-Ecoleta-advanced

Rodrigo001-dev avatar Jul 03 '20 01:07 Rodrigo001-dev

Hey @zairigimad!

Do you need a hand with that PR?

It would be great to have Svelte's support in webpack encore.

If I can help in any way, let me know!

Volubyl avatar Dec 21 '20 16:12 Volubyl

@Volubyl yes it will be great if you can help :)

zairigimad avatar Dec 21 '20 18:12 zairigimad

@Volubyl yes it will be great if you can help :)

Nice!

Can you tell me what remains to be done with this PR and how I can help?

Volubyl avatar Dec 22 '20 07:12 Volubyl

@Volubyl yes it will be great if you can help :)

Nice!

Can you tell me what remains to be done with this PR and how I can help?

when I've added this, it was working, maybe if you can test it and see if something missing or if you have and idea you can add it :)

zairigimad avatar Dec 22 '20 18:12 zairigimad

Sorry for letting this sit for SO long without any attention :/.

The only thing I can see that this is missing is a test in functional.js. It would probably include adding a "hello world" type of svelte file into the fixtures, then booting up an Encore setup, executing Encore and asserting that the result works. We have plenty of examples of that sort of thing in that functional.js file - React or Vue might be especially good examples to pull from.

Cheers!

no problem, I will make the test ASAP.

zairigimad avatar Apr 23 '21 15:04 zairigimad

Hey @weaverryan I've added the functional test for svelte :)

zairigimad avatar Apr 28 '21 20:04 zairigimad

Any chances to be merged in near future?

CrazyHackGUT avatar Jul 09 '21 08:07 CrazyHackGUT

Thank you @zairigimad! I'm so sorry - and embarrassed by how much this fell off my radar. Apologies for the insane delay, but this is excellent work!

weaverryan avatar Oct 10 '22 13:10 weaverryan

Thank you @zairigimad! I'm so sorry - and embarrassed by how much this fell off my radar. Apologies for the insane delay, but this is excellent work!

No problem you are doing an incredible work maintaining lot of things in Symfony ecosystem, thanks to you. I’m very happy that it’s finally merged 🎉

zairigimad avatar Oct 10 '22 14:10 zairigimad