webpack-encore
webpack-encore copied to clipboard
`enableBuildNotifications` should not be enabled by default
Why does default encore come with enableBuildNotifications
on by default. Maybe it's my hate for notifications but In general I feel like things should not just install/run "random" binaries by default.
It comes from ..\encore-test\node_modules\node-notifier\vendor\snoreToast\snoretoast-x64.exe
. And for me on windows it even created a shortcut in my start menu without any consent. While at the same time not removing it when I remove encore (or npm's node-notifier
).
I feel like the consequences of that enabled should be clearly explained in the config and manually be enabled.
I'm also in favor in this, I've always removed the .enableBuildNotifications()
from the configuration file and the webpack-notifier
dependency.
I never found those notifications very useful, but that's just my opinion.
I'm fine with disabling by default - it would be over in the recipe - https://github.com/symfony/recipes/blob/main/symfony/webpack-encore-bundle/1.10/webpack.config.js - we could also then remove https://github.com/symfony/recipes/blob/main/symfony/webpack-encore-bundle/1.10/package.json#L12
Cheers!