ux icon indicating copy to clipboard operation
ux copied to clipboard

[Notify] Allow "body" and possibly other Notification Options

Open weaverryan opened this issue 3 years ago • 2 comments

The Notify component currently does this in JavaScript:

new Notification(content);

But, Notification has a 2nd options argument - https://developer.mozilla.org/en-US/docs/Web/API/Notification/Notification#parameters - where various other options can be passed, mostly notably body.

At the very least, we could pass the content from a Notifier object to this. So, in php:

$notification = new Notification($message, ['chat/custom_mercure_chatter_transport']);
$notification->content('I will now show up as the body');
$notifier->send($notification);

The JavaScript Notification has many other options, e.g. actions and icon. I'm not sure how/if we can support/send these from Symfony's Notifier or not.

Any thoughts @mtarld?

weaverryan avatar Jun 16 '22 14:06 weaverryan

Indeed, that's a great idea! I think we can leverage the MercureOptions of symfony/mercure-notifier in order to add such options. But IMHO, we might have to find a way to avoid mixing up mercure-related stuff and notification-related stuff WDYT?

mtarld avatar Jun 20 '22 10:06 mtarld

I would like to have this feature. but i don't know where _notify in controller.js get his content. And if I use {{ stream_notifications(nummern, {'data-controller': 'mynotify'} ) }} then, _notify in my mynotify-controller.js are not used.

ernie76 avatar Jan 19 '24 07:01 ernie76