ux icon indicating copy to clipboard operation
ux copied to clipboard

[Toolkit][Shadcn] Add DropdownMenu component

Open daFish opened this issue 1 month ago • 3 comments

Q A
Bug fix? no
New feature? yes
Deprecations? no
Documentation? yes
Issues Tracked in #3233
License MIT

Add DropdownMenu as a component with support for checkboxes, radio group, and dialog. It utilizes the already available components like Kbd and Dialog. The Button Group component is also updated to use the new component.

ref: https://ui.shadcn.com/docs/components/dropdown-menu

daFish avatar Dec 12 '25 18:12 daFish

I have also added support for dropdown-menu in button group.

/cc @bernard-ng

daFish avatar Dec 13 '25 10:12 daFish

Hi!

I started to look at your work, and thanks you so much for that!

However, I find there is too much logic in the dropdown_menu_controller.js, and I feel like it could be super-simplified by using these new features:

  • https://developer.chrome.com/blog/command-and-commandfor
  • https://developer.mozilla.org/en-US/docs/Web/CSS/Guides/Anchor_positioning?

Thanks!

Kocal avatar Dec 16 '25 05:12 Kocal

@Kocal How to handle custom styles? Should I import them in the controller or is this something to be handled in user land?

daFish avatar Dec 16 '25 09:12 daFish