[Autocomplete] Add `maxOptions: null` to autocomplete with remote data

Open kevinmade opened this issue 7 months ago • 3 comments

Q A

Bug fix? yes

New feature? no

Docs? no

License MIT

Q	A
Bug fix?	yes
New feature?	no
Docs?	no
License	MIT

This fixes an issue where the autocomplete component stops loading additional results after 50 due to default limit. The maxOptions value has been set to null to allow loading more than 50 options from the autocomplete_url.

Jun 04 '25 13:06 kevinmade

📊 Packages dist files size difference

Thanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR. Please review the changes and make sure they are expected.

File	Before (Size / Gzip)	After (Size / Gzip)
Autocomplete
`controller.d.ts`	`1.95 kB` / `656 B`	`2.02 kB`^{+4% 📈} / `667 B`^{+2% 📈}
`controller.js`	`14.99 kB` / `3.87 kB`	`15.19 kB`^{+1% 📈} / `3.9 kB`^{+1% 📈}

Jun 04 '25 13:06 github-actions[bot]

Before

https://github.com/user-attachments/assets/8bd779e1-ce69-4713-a418-7c0dde8317b8

After

https://github.com/user-attachments/assets/f2b96d95-0762-4315-ae0f-807efac728d9

Jun 05 '25 13:06 kevinmade

When seeing your demo, I think it breaks the spirit of "autocompletion". To me, you have to type something and the component autocomplete you some results, but here, it looks like a lazy-loaded <select> and it feels wrong to me.

I'm not really against your suggestion, but not in this way. Instead, can we keep it 50 items by default but introduce a new option?

Jun 09 '25 20:06 Kocal