ux icon indicating copy to clipboard operation
ux copied to clipboard

[Autocomplete] Only activate clear button plugin when there is a placeholder option

Open Qronicle opened this issue 1 year ago • 1 comments

Q A
Bug fix? yes
New feature? maybe?
Issues Fix #402
License MIT

Only add the clear_button plugin to TomSelect if the form element has no placeholder option.

Notes:

  • I defined 'having a placeholder' as the select having an option with an empty value, as that is what TomSelect also seems to do
  • I'm not 100% sure about whether this needs a test or how to even run tests locally

Qronicle avatar Oct 18 '24 16:10 Qronicle

Form the monorepository root

Install dependencies

yarn install 

Code style

yarn run lint
yarn run format

Run Tests

yarn run test

Build dist packages

yarn run test

(you need to commit both src/Autocomplete/assets/src/** and src/Autocomplete/assets/dist/** files in this PR)

Please ask if you want/need anymore information :)

smnandre avatar Oct 23 '24 22:10 smnandre

Status: Needs work

Kocal avatar Jan 05 '25 19:01 Kocal

Sorry guys, I somehow missed the review notifications. Will try and clear some time to dive back into this.

Qronicle avatar Jan 08 '25 11:01 Qronicle

No worry, we cannot criticize anyone on time things .... 😅

(well, we cannot criticize anyone on anything just to be clear 😄 )

smnandre avatar Jan 08 '25 11:01 smnandre

@Qronicle do you have a bit of time to fix your PR? :eyes:

LucileDT avatar Jul 11 '25 14:07 LucileDT

I am closing due to inactivity, feel free to re-open the PR if necessary. Thanks for the contribution!

Kocal avatar Oct 09 '25 09:10 Kocal