symfony icon indicating copy to clipboard operation
symfony copied to clipboard

[Serializer] Rework `XmlEncoderTest`

Open OskarStark opened this issue 1 year ago • 1 comments

Q A
Branch? 7.1
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

I moved to use a data provider instead of extra test methods.

Would you accept this PR? If yes, I will finish it

OskarStark avatar May 02 '24 12:05 OskarStark

That's nice! If this get accepted, don't forget to declare your new data providers static, a few ones are missing in the current codebase and will be fixed here https://github.com/symfony/symfony/pull/54824 🙂

alexandre-daubois avatar May 02 '24 14:05 alexandre-daubois

Ready to merge from my side

OskarStark avatar Jul 13 '24 07:07 OskarStark

Rebased

OskarStark avatar Jul 26 '24 12:07 OskarStark

Rebased

OskarStark avatar Aug 02 '24 19:08 OskarStark

Thank you @OskarStark.

fabpot avatar Aug 03 '24 09:08 fabpot