symfony icon indicating copy to clipboard operation
symfony copied to clipboard

[Notifier] Add Primotexto bridge

Open Goazil opened this issue 1 year ago • 3 comments

Q A
Branch? 7.2
Bug fix? no
New feature? yes
Deprecations? no
Issues none
License MIT

This PR adds a new bridge for Primotexto. Based on documentation available here: https://www.primotexto.com/

Goazil avatar Apr 26 '24 13:04 Goazil

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

carsonbot avatar Apr 26 '24 13:04 carsonbot

Thanks for the review @OskarStark, I hope it's okay now :)

Goazil avatar Apr 29 '24 06:04 Goazil

Can be merged into 7.2 if available

OskarStark avatar Apr 29 '24 08:04 OskarStark

Thank you @Goazil.

fabpot avatar May 31 '24 06:05 fabpot