symfony-docs icon indicating copy to clipboard operation
symfony-docs copied to clipboard

[Webhook] decouple the Webhook component from the Serializer component

Open fabpot opened this issue 1 year ago • 1 comments

Q A
Feature PR symfony/symfony#57881
PR author(s) @xabbuh
Merged in 7.2

We created this issue to not forget to document this new feature. We would really appreciate if you can help us with this task. If you are not sure how to do it, please ask us and we will help you.

To fix this issue, please create a PR against the 7.2 branch in the symfony-docs repository.

Thank you! :smiley:

fabpot avatar Aug 14 '24 16:08 fabpot

Webhook documentation doesn't mention Serializer as a requirement, I think there is no change to do for 7.2 But event if it is an undesirable behaviour what about adding a note for previous versions ?

MrYamous avatar Sep 06 '24 12:09 MrYamous

In <7.2 if symfony/serializer is not installed an exception is thrown (described in original issue https://github.com/symfony/symfony/issues/57567)

With this PR, webhook component will fallback to a native json_encode instead (https://github.com/symfony/symfony/pull/57881/files#diff-e4f52d5033296421d02e360c8355aa1931bdfb0c12579f4815ea02b724322c0cR2935)

So maybe we have nothing to document, because no BC break ?

alamirault avatar Mar 18 '25 20:03 alamirault

I agree. Let's close here. Thanks for checking @alamirault.

xabbuh avatar Mar 19 '25 09:03 xabbuh