symfony-docs icon indicating copy to clipboard operation
symfony-docs copied to clipboard

[Emoji] Emoji component

Open smnandre opened this issue 1 year ago • 2 comments

Emoji documentation

(Issue: #19484)

smnandre avatar Feb 03 '24 15:02 smnandre

Run ../_checker/code-block-checker.php verify:docs `pwd` components/emoji.rst components/intl.rst  --baseline=baseline.json --output-format=github --symfony-application=`realpath ../_sf_app`

Error: [Missing class] Class, interface or trait with name "Symfony\Component\Emoji\EmojiTransliterator" does not exist
Error: [Missing class] Class, interface or trait with name "Symfony\Component\Emoji\EmojiTransliterator" does not exist
Error: Process completed with exit code 1.

Does that mean Emoji component must be added to the symfony app ?

smnandre avatar Feb 16 '24 16:02 smnandre

Thank you for the feedback @javiereguiluz !

The CI stays red (will stay red until we add "emoji" to the stimulus app used in this CI workflow i think)

Anything i can add / imrpove ?

smnandre avatar Feb 20 '24 15:02 smnandre

Simon, thanks a lot for this 🙌 This is now merged!

Note that while merging we reorganized contents a bit. We discussed internally in the Symfony Docs team and decided to do so because we don't want to add new docs under components/ namespace. We want to remove all components/ docs and move it to normal articles. So, we've deleted components/emoji.rst and moved its contents to components/string.rst (see https://github.com/symfony/symfony-docs/commit/9333df7a418202a9efb4e4cc62bc2698bf13aaa9). In a future PR we're going to move components/string.rst to string.rst. Thanks!

javiereguiluz avatar Mar 11 '24 09:03 javiereguiluz

We discussed internally in the Symfony Docs team and decided to do so because we don't want to add new docs under components/ namespace.

Ok noted for the future

Note that while merging we reorganized contents a bit.

Thanks for the heads up and explanation! Makes a lot of sense :)

smnandre avatar Mar 12 '24 17:03 smnandre