symfony-docs icon indicating copy to clipboard operation
symfony-docs copied to clipboard

[Serializer] Add documentation about a new XmlEncoder CDATA wrapping opt-out context option

Open AndoniLarz opened this issue 1 year ago • 7 comments

Add documentation of https://github.com/symfony/symfony/pull/49893 which has been merged in 6.4.

TODO :

  • [x] Fix conflicts (by rebasing)
  • [x] Edit the context option name (enable_cdata_wrapping => cdata_wrapping)
  • [x] Wait for the reviews

AndoniLarz avatar Apr 01 '23 16:04 AndoniLarz

Hi @xabbuh @OskarStark , I fixed the conflicts and updated the context option name following the code that has been merged. Does it look good to you ?

AndoniLarz avatar Apr 29 '24 08:04 AndoniLarz

Please target 7.1 branch for now, thanks

OskarStark avatar Apr 29 '24 08:04 OskarStark

Please target 7.1 branch for now, thanks

Even though the feature has been added in 6.4 ?

AndoniLarz avatar Apr 29 '24 08:04 AndoniLarz

Even though the feature has been added in 6.4 ?

Ah sorry this is about another option. Sorry I mixed things up. No in this car 6.4 is fine, but a versionadded would be helpful at all:


.. versionadded:: 6.4

    The `cdata_wrapping` option was introduced in Symfony 6.4.

OskarStark avatar Apr 29 '24 09:04 OskarStark

Even though the feature has been added in 6.4 ?

Ah sorry this is about another option. Sorry I mixed things up. No in this car 6.4 is fine, but a versionadded would be helpful at all:


.. versionadded:: 6.4

    The `cdata_wrapping` option was introduced in Symfony 6.4.

Alright no problem. I'll make the changes soon

AndoniLarz avatar Apr 29 '24 09:04 AndoniLarz

Open for finishing this PR by handling my comments?

OskarStark avatar May 15 '24 03:05 OskarStark

Open for finishing this PR by handling my comments?

It should be good now :smile:

AndoniLarz avatar May 15 '24 12:05 AndoniLarz

Thank you Andoni and congratulations on your first contribution to the Symfony documentation 🎉

OskarStark avatar May 16 '24 05:05 OskarStark