symfony-docs icon indicating copy to clipboard operation
symfony-docs copied to clipboard

Published 20 hours ago • verified publisher icon symfony

Typo fix

Open andyexeter opened this issue 2 years ago • 1 comments

"Secret" should be plural "Secrets" in this context.

andyexeter avatar Aug 12 '22 11:08 andyexeter

This title exists in Symfony 4.4 https://symfony.com/doc/4.4/best_practices.html#use-secret-for-sensitive-information I think the PR should target 4.4.

alexislefebvre avatar Aug 12 '22 13:08 alexislefebvre

What's the best way of updating the PR to target 4.4? I tried to change the base via github but it brought across hundreds of other commits.

andyexeter avatar Aug 14 '22 11:08 andyexeter

@andyexeter

  • easiest method: close this PR, edit the file from the 4.4 branch and open a PR targeting 4.4
  • more complicated method: rebasing may be too much work, but you can checkout the 4.4 branch locally, cherry-pick your commit, then push force on the branch of this PR, and finally change the targeted branch in this PR

alexislefebvre avatar Aug 15 '22 01:08 alexislefebvre

We can merge it against 4.4 no problem 😃

OskarStark avatar Aug 15 '22 05:08 OskarStark

Thank you @andyexeter.

xabbuh avatar Aug 15 '22 09:08 xabbuh