symfony-docs icon indicating copy to clipboard operation
symfony-docs copied to clipboard

[Notifier] Add Documentation for Events

Open ismail1432 opened this issue 3 years ago • 4 comments

I would like to add documentation for the events available in the Notifier, see https://github.com/symfony/symfony-docs/issues/15589

I don't know if I have the good approach (create a specific page like for console events)

ismail1432 avatar Aug 06 '21 16:08 ismail1432

I would rathee document it like workflow component events (sub part of doc and not new page) Nice addition :)

94noni avatar Dec 28 '21 05:12 94noni

I guess we need to link your new page here https://symfony.com/doc/current/notifier.html#learn-more

welcoMattic avatar Jul 12 '22 15:07 welcoMattic

I guess we need to link your new page here https://symfony.com/doc/current/notifier.html#learn-more

Thanks @welcoMattic, from what I understand the instruction notifier/* in file means all pages in the notifier folder will be automatically added so nothing to do specifically.

Learn more
----------

.. toctree::
    :maxdepth: 1
    :glob:

    notifier/*

ismail1432 avatar Jul 13 '22 14:07 ismail1432

@javiereguiluz can you review this one please? I guess it's ok, but I'm not RST master :smile:

welcoMattic avatar Jul 30 '22 11:07 welcoMattic

Hello @OskarStark

Thanks for the review and sorry for the delay I missed the notifications.

ismail1432 avatar Oct 29 '22 15:10 ismail1432

friendly ping 👋

ismail1432 avatar Nov 13 '22 14:11 ismail1432

It took time, but here we go, this is in now. Thank you very much Smaine.

OskarStark avatar Dec 04 '22 20:12 OskarStark

I added a versionadded directive after merging

OskarStark avatar Dec 04 '22 20:12 OskarStark

No worries @OskarStark and big Thanks for following 👍

ismail1432 avatar Dec 05 '22 08:12 ismail1432