POST_SUBMIT_EVENT improvement?

[DonCallisto]

Reading https://symfony.com/doc/current/form/events.html#c-the-formevents-post-submit-event, even if it's true that's clearly stated

It can be used to fetch data after denormalization.

it is, correctly, just an advice. No one prevents the user to set data directly on the underlying form object (after some logic applied, for example?). This will result possibly in a validation happening before new data taking place as ValidationListener has no priority declared (https://github.com/symfony/form/blob/master/Extension/Validator/EventListener/ValidationListener.php#L35).

Proposal

Warn explicitly the user, through the doc page, about this eventuality. If this makes sense to you, let me know and I'll make a PR.

PS.: I was wondering if ValidationListener has the right behaviour: as long as form component can't prevent someone to modify data after validation (and that's not possible at all), ValidationListener should be registered with PHP_MAX_INT priority (minus 1, in order to let someone to act before data validation?) to take shelter of this kind of issues. I think it would be a good idea because, as this component is designed, validation is "automatically" done by component itself so, as long as validation is expected, why shouldn't we care when it actually happens? It makes sense?

[DonCallisto]

Did anyone had the chance to look at this?

[carsonbot]

Thank you for this issue. There has not been a lot of activity here for a while. Has this been resolved?

[DonCallisto]

Still waiting for a feedback

[xabbuh]

@DonCallisto Please open a PR. We can discuss the proper wording there. :)

[carsonbot]

Thank you for this issue. There has not been a lot of activity here for a while. Has this been resolved?

[carsonbot]

Hello? This issue is about to be closed if nobody replies.

[carsonbot]

Hey,

I didn't hear anything so I'm going to close it. Feel free to comment if this is still relevant, I can always reopen!