recipes icon indicating copy to clipboard operation
recipes copied to clipboard

joli-notif-notifier inserted commented-out .env var

Open tacman opened this issue 6 months ago • 2 comments

when adding symfony/joli-notif-notifier to a project, the env var is commented out.

 composer req symfony/joli-notif-notifier
cat .env

###> symfony/joli-notif-notifier ###
# JOLINOTIF_DSN=jolinotif://default
###< symfony/joli-notif-notifier ###

I can't find anything in the recipe that does this, and I don't understand why anyone would want to, since it's an extra step the first time you try to use it.

tacman avatar May 22 '25 15:05 tacman

The env var is commented here https://github.com/symfony/recipes/blob/main/symfony/joli-notif-notifier/7.2/manifest.json#L12, and it looks like it's the same behaviour for allo other notifiers.

If we want to add the env var to .env without the comment, we can use something like https://github.com/symfony/recipes/blob/main/symfony/ux-leaflet-map/2.19/manifest.json#L8

Kocal avatar May 22 '25 16:05 Kocal

Thanks, I've I've submitted a PR.

tacman avatar May 22 '25 17:05 tacman