recipes-contrib
recipes-contrib copied to clipboard
Recipes/easy fields bundle
Thanks for the PR 😍
How to test these changes in your application
-
Define the
SYMFONY_ENDPOINTenvironment variable:# On Unix-like (BSD, Linux and macOS) export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1328/index.json # On Windows SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1328/index.json -
Install the package(s) related to this recipe:
composer req 'symfony/flex:^1.16' composer req 'agence-adeliom/easy-fields-bundle:^1.0' -
Don't forget to unset the
SYMFONY_ENDPOINTenvironment variable when done:# On Unix-like (BSD, Linux and macOS) unset SYMFONY_ENDPOINT # On Windows SET SYMFONY_ENDPOINT=
Diff between recipe versions
In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes. I'm going keep this comment up to date with any updates of the attached patch.
I think you should remove all the PHP code from the recipes and create a command in your bundle that can generate those files. A recipe is not the right abstraction for generating PHP classes that are part of the end-user code. It's mostly for configuration files.
Closing for now as we cannot merge it as is. Feel free to reopen if/when the bundles can generate the PHP code.