recipes-contrib icon indicating copy to clipboard operation
recipes-contrib copied to clipboard

Recipes/easy fields bundle

Open arnaud-ritti opened this issue 3 years ago • 1 comments

Q A
License MIT
Packagist https://packagist.org/packages/agence-adeliom/easy-fields-bundle

arnaud-ritti avatar Dec 20 '21 15:12 arnaud-ritti

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1328/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1328/index.json
    
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 'agence-adeliom/easy-fields-bundle:^1.0'
    
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=
    

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes. I'm going keep this comment up to date with any updates of the attached patch.

github-actions[bot] avatar Dec 20 '21 15:12 github-actions[bot]

I think you should remove all the PHP code from the recipes and create a command in your bundle that can generate those files. A recipe is not the right abstraction for generating PHP classes that are part of the end-user code. It's mostly for configuration files.

Closing for now as we cannot merge it as is. Feel free to reopen if/when the bundles can generate the PHP code.

fabpot avatar Dec 30 '22 09:12 fabpot