recipes-contrib icon indicating copy to clipboard operation
recipes-contrib copied to clipboard

Add Sylius RichEditor v2 recipe

Open maximehuran opened this issue 2 years ago • 3 comments

Q A
License MIT
Packagist

maximehuran avatar Oct 26 '21 17:10 maximehuran

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On *nix and Mac
    export SYMFONY_ENDPOINT=https://api.github.com/repos/symfony/recipes-contrib/contents/index.json?ref=flex/pull-1290
    # On Windows
    SET SYMFONY_ENDPOINT=https://api.github.com/repos/symfony/recipes-contrib/contents/index.json?ref=flex/pull-1290
    
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 'monsieurbiz/sylius-rich-editor-plugin:^2.0'
    
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On *nix and Mac
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=
    

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes. I'm going keep this comment up to date with any updates of the attached patch.

monsieurbiz/sylius-rich-editor-plugin

1.0 vs 2.0
diff --git a/monsieurbiz/sylius-rich-editor-plugin/1.0/config/routes/monsieurbiz_sylius_rich_editor_plugin.yaml b/monsieurbiz/sylius-rich-editor-plugin/2.0/config/routes/monsieurbiz_sylius_rich_editor_plugin.yaml
index d6979d2e..c770b017 100644
--- a/monsieurbiz/sylius-rich-editor-plugin/1.0/config/routes/monsieurbiz_sylius_rich_editor_plugin.yaml
+++ b/monsieurbiz/sylius-rich-editor-plugin/2.0/config/routes/monsieurbiz_sylius_rich_editor_plugin.yaml
@@ -1,2 +1,3 @@
-monsieur_biz_rich_editor_plugin:
-    resource: "@MonsieurBizSyliusRichEditorPlugin/Resources/config/routing.yaml"
+monsieurbiz_richeditor_admin:
+    resource: "@MonsieurBizSyliusRichEditorPlugin/Resources/config/routing/admin.yaml"
+    prefix: /%sylius_admin.path_name%

github-actions[bot] avatar Oct 26 '21 17:10 github-actions[bot]

Can it be merged ? 🤩

maximehuran avatar Feb 21 '22 08:02 maximehuran

Could you please rebase to the CI is happy?

I cannot merge otherwise.

Nyholm avatar Mar 09 '22 15:03 Nyholm