recipes-contrib
recipes-contrib copied to clipboard
Add recipe for monsieurbiz/sylius-rich-editor-plugin in v2
| Q | A |
|---|---|
| License | MIT |
See https://github.com/symfony/recipes-contrib/pull/914 for the v1.
The recipe is almost the same. The routing is a bit different and needs a new version of the recipe.
@symfony-flex-server review please
Isn't the error a bit strange @Nyholm? It cannot read the files?
Thanks for the PR 😍
How to test these changes in your application
-
Define the
SYMFONY_ENDPOINTenvironment variable:# On Unix-like (BSD, Linux and macOS) export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1147/index.json # On Windows SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1147/index.json -
Install the package(s) related to this recipe:
composer req 'symfony/flex:^1.16' composer req 'monsieurbiz/sylius-rich-editor-plugin:^2.0' -
Don't forget to unset the
SYMFONY_ENDPOINTenvironment variable when done:# On Unix-like (BSD, Linux and macOS) unset SYMFONY_ENDPOINT # On Windows SET SYMFONY_ENDPOINT=
Diff between recipe versions
In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes. I'm going keep this comment up to date with any updates of the attached patch.
monsieurbiz/sylius-rich-editor-plugin
1.0 vs 2.0
diff --git a/monsieurbiz/sylius-rich-editor-plugin/1.0/config/routes/monsieurbiz_sylius_rich_editor_plugin.yaml b/monsieurbiz/sylius-rich-editor-plugin/2.0/config/routes/monsieurbiz_sylius_rich_editor_plugin.yaml
index d6979d2e..c770b017 100644
--- a/monsieurbiz/sylius-rich-editor-plugin/1.0/config/routes/monsieurbiz_sylius_rich_editor_plugin.yaml
+++ b/monsieurbiz/sylius-rich-editor-plugin/2.0/config/routes/monsieurbiz_sylius_rich_editor_plugin.yaml
@@ -1,2 +1,3 @@
-monsieur_biz_rich_editor_plugin:
- resource: "@MonsieurBizSyliusRichEditorPlugin/Resources/config/routing.yaml"
+monsieurbiz_richeditor_admin:
+ resource: "@MonsieurBizSyliusRichEditorPlugin/Resources/config/routing/admin.yaml"
+ prefix: /%sylius_admin.path_name%
Thank you. Do you know why the ci fails to install this package on sf 5?
Thank you. Do you know why the ci fails to install this package on sf 5?
We may have an issue on the dependencies, I'll have a look next week! Thank you!
Hey. Dont forget about this PR.
Hey @jacquesbh, any news about the dependency issue?