recipes-contrib icon indicating copy to clipboard operation
recipes-contrib copied to clipboard

Add recipe for monsieurbiz/sylius-rich-editor-plugin in v2

Open jacquesbh opened this issue 4 years ago • 7 comments

Q A
License MIT

See https://github.com/symfony/recipes-contrib/pull/914 for the v1.

The recipe is almost the same. The routing is a bit different and needs a new version of the recipe.

jacquesbh avatar May 10 '21 16:05 jacquesbh

@symfony-flex-server review please

Nyholm avatar May 11 '21 19:05 Nyholm

Isn't the error a bit strange @Nyholm? It cannot read the files?

jacquesbh avatar May 12 '21 08:05 jacquesbh

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1147/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1147/index.json
    
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 'monsieurbiz/sylius-rich-editor-plugin:^2.0'
    
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=
    

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes. I'm going keep this comment up to date with any updates of the attached patch.

monsieurbiz/sylius-rich-editor-plugin

1.0 vs 2.0
diff --git a/monsieurbiz/sylius-rich-editor-plugin/1.0/config/routes/monsieurbiz_sylius_rich_editor_plugin.yaml b/monsieurbiz/sylius-rich-editor-plugin/2.0/config/routes/monsieurbiz_sylius_rich_editor_plugin.yaml
index d6979d2e..c770b017 100644
--- a/monsieurbiz/sylius-rich-editor-plugin/1.0/config/routes/monsieurbiz_sylius_rich_editor_plugin.yaml
+++ b/monsieurbiz/sylius-rich-editor-plugin/2.0/config/routes/monsieurbiz_sylius_rich_editor_plugin.yaml
@@ -1,2 +1,3 @@
-monsieur_biz_rich_editor_plugin:
-    resource: "@MonsieurBizSyliusRichEditorPlugin/Resources/config/routing.yaml"
+monsieurbiz_richeditor_admin:
+    resource: "@MonsieurBizSyliusRichEditorPlugin/Resources/config/routing/admin.yaml"
+    prefix: /%sylius_admin.path_name%

github-actions[bot] avatar Sep 10 '21 12:09 github-actions[bot]

Thank you. Do you know why the ci fails to install this package on sf 5?

Nyholm avatar Sep 10 '21 16:09 Nyholm

Thank you. Do you know why the ci fails to install this package on sf 5?

We may have an issue on the dependencies, I'll have a look next week! Thank you!

jacquesbh avatar Sep 10 '21 17:09 jacquesbh

Hey. Dont forget about this PR.

Nyholm avatar Feb 19 '22 10:02 Nyholm

Hey @jacquesbh, any news about the dependency issue?

vvasiloi avatar Mar 09 '22 15:03 vvasiloi