polyfill icon indicating copy to clipboard operation
polyfill copied to clipboard

Conform to IDNA version 15.1.0 revision 31

Open TRowbotham opened this issue 1 year ago • 4 comments

This adds the necessary changes to conform to IDNA version 15.1.0 revision 31.

Notable Changes

  • Transitional processing (the default in PHP) is now deprecated. No deprecation notices were added as PHP does not yet report a deprecation notice in this case.
  • An error is no longer recorded for characters with a status of disallowed.
  • When performing code point mapping and transitional processing is enabled the code point U+1E9E capital sharp s (ẞ), is replaced by the string “ss”
  • A new internal option "IgnoreInvalidPunycode" was added, which is supposed to allow for an all-ASCII fast-path, however, the official tests do not test this configuration option.

TRowbotham avatar Nov 06 '23 21:11 TRowbotham

Can we add a test?

derrabus avatar Nov 07 '23 03:11 derrabus

I don't think we should add options that don't exist in PHP. This would defeat the purpose of this library.

stof avatar Nov 07 '23 08:11 stof

I have decided to remove the "IgnoreInvalidPunycode" option as suggested since the option is not available in PHP.

TRowbotham avatar Nov 08 '23 23:11 TRowbotham

I fixed my CS comments by force-pushing on your fork. Tests would still be welcome. And I have one question (see inline comments). Are you still interested in finishing this PR?

Yes, sorry, haven't had a lot of free time lately. I'll try to put some tests together this week.

Thanks for taking care of the style issues.

TRowbotham avatar Jan 30 '24 22:01 TRowbotham

Thank you @TRowbotham.

nicolas-grekas avatar Apr 12 '24 09:04 nicolas-grekas