monolog-bundle icon indicating copy to clipboard operation
monolog-bundle copied to clipboard

Published 20 hours ago • verified publisher icon symfony

fixes #342 add rfc option for syslogudp handler

Open gwinn opened this issue 4 years ago • 6 comments

gwinn avatar Mar 04 '20 15:03 gwinn

Can you review latest changes?

gwinn avatar Jul 03 '20 15:07 gwinn

Hi! When can we expect a merge? This very important for me. It seems like nothing else prevents the merge.

iyzoer avatar Jan 19 '21 07:01 iyzoer

Also highly requested from my side, need it to select RFC5424e (time with miliseconds) for SyslogUDP logging.

HontoNoRoger avatar Jan 25 '21 12:01 HontoNoRoger

It would be nice to have a test case in Tests/DependencyInjection/ConfigurationTest.php to see if the default is used when rfc is not set in config and another case for when an invalid number is picked.

Done

gwinn avatar Feb 01 '21 17:02 gwinn

Can I expect a review soon? It seems to me important and necessary to contribute to open source projects, especially if the proposed changes are needed not only by one developer, but, frankly, it is a little confusing how quickly the library development team considers proposals, this PR was created a year ago

gwinn avatar Mar 25 '21 10:03 gwinn

A last comment for my side ;-).

Don't forget to add an entry in the ChangeLog pray

done )

gwinn avatar Mar 31 '21 09:03 gwinn